PMD Results

The following document contains the results of PMD 6.53.0.

Violations By Priority

Priority 1

nl/knaw/dans/bagit/conformance/BagLinter.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 63
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 63
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 64
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 64

nl/knaw/dans/bagit/conformance/BagProfileChecker.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 57
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 57
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 58
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 58

nl/knaw/dans/bagit/conformance/BagitWarning.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 42
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 42

nl/knaw/dans/bagit/conformance/EncodingChecker.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 32
FieldNamingConventions The public constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 32
FieldNamingConventions The public constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 33
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 33

nl/knaw/dans/bagit/conformance/ManifestChecker.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 52
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 52
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 53
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 53

nl/knaw/dans/bagit/conformance/MetadataChecker.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 37
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 37
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 38
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 38

nl/knaw/dans/bagit/conformance/VersionChecker.java

Rule Violation Line
FieldNamingConventions The public constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 32
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 32
FieldNamingConventions The public constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 34
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 34

nl/knaw/dans/bagit/conformance/profile/BagitProfileDeserializer.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 42
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 42
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 43
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 43

nl/knaw/dans/bagit/conformance/profile/Serialization.java

Rule Violation Line
FieldNamingConventions The enum constant name 'forbidden' doesn't match '[A-Z][A-Z_0-9]*' 22
FieldNamingConventions The enum constant name 'required' doesn't match '[A-Z][A-Z_0-9]*' 23
FieldNamingConventions The enum constant name 'optional' doesn't match '[A-Z][A-Z_0-9]*' 24

nl/knaw/dans/bagit/creator/AbstractCreateManifestsVistor.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 39
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 39
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 40
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 40

nl/knaw/dans/bagit/creator/BagCreator.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 51
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 51
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 52
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 52

nl/knaw/dans/bagit/domain/Version.java

Rule Violation Line
MethodNamingConventions The static method name 'LATEST_BAGIT_VERSION' doesn't match '[a-z][a-zA-Z0-9]*' 35–37

nl/knaw/dans/bagit/hash/Hasher.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 42
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 42
FieldNamingConventions The constant name '_64_KB' doesn't match '[A-Z][A-Z_0-9]*' 43
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 45
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 45

nl/knaw/dans/bagit/hash/StandardBagitAlgorithmNameToSupportedAlgorithmMapping.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 28
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 28

nl/knaw/dans/bagit/reader/BagitTextFileReader.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 41
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 41
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 43
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 43

nl/knaw/dans/bagit/reader/FetchReader.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 39
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 39
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 40
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 40

nl/knaw/dans/bagit/reader/KeyValueReader.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 38
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 38
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 40
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 40

nl/knaw/dans/bagit/reader/ManifestReader.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 45
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 45
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 46
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 46

nl/knaw/dans/bagit/reader/MetadataReader.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 36
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 36
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 37
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 37

nl/knaw/dans/bagit/reader/TagFileReader.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 36
FieldNamingConventions The public constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 36
FieldNamingConventions The public constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 37
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 37

nl/knaw/dans/bagit/verify/AbstractPayloadFileExistsInManifestsVistor.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 35
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 35
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 36
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 36

nl/knaw/dans/bagit/verify/BagVerifier.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 52
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 52
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 53
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 53

nl/knaw/dans/bagit/verify/CheckIfFileExistsTask.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 35
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 35
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 36
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 36

nl/knaw/dans/bagit/verify/CheckManifestHashesTask.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 40
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 40
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 41
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 41

nl/knaw/dans/bagit/verify/FileCountAndTotalSizeVistor.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 34
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 34
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 35
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 35

nl/knaw/dans/bagit/verify/MandatoryVerifier.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 43
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 43
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 44
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 44

nl/knaw/dans/bagit/verify/ManifestVerifier.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 50
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 50
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 51
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 51
MethodNamingConventions The static method name 'CheckAllFilesInPayloadDirAreListedInAllManifests' doesn't match '[a-z][a-zA-Z0-9]*' 188–194

nl/knaw/dans/bagit/verify/PayloadFileExistsInAtLeastOneManifestVistor.java

Rule Violation Line
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 34
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 34

nl/knaw/dans/bagit/verify/QuickVerifier.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 39
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 39
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 40
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 40

nl/knaw/dans/bagit/writer/BagWriter.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 39
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 39
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 40
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 40

nl/knaw/dans/bagit/writer/BagitFileWriter.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 35
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 35
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 36
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 36

nl/knaw/dans/bagit/writer/FetchWriter.java

Rule Violation Line
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 36
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 36
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 37
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 37

nl/knaw/dans/bagit/writer/ManifestWriter.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 37
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 37
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 38
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 38

nl/knaw/dans/bagit/writer/MetadataWriter.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 35
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 35
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 37
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 37

nl/knaw/dans/bagit/writer/PayloadWriter.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 38
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 38
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 40
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 40

Priority 2

nl/knaw/dans/bagit/conformance/BagLinter.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 147
GuardLogStatement Logger calls should be surrounded by log level guards. 150
GuardLogStatement Logger calls should be surrounded by log level guards. 153
GuardLogStatement Logger calls should be surrounded by log level guards. 156
GuardLogStatement Logger calls should be surrounded by log level guards. 164
GuardLogStatement Logger calls should be surrounded by log level guards. 168
GuardLogStatement Logger calls should be surrounded by log level guards. 176

nl/knaw/dans/bagit/conformance/BagProfileChecker.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 114
GuardLogStatement Logger calls should be surrounded by log level guards. 135
GuardLogStatement Logger calls should be surrounded by log level guards. 145
GuardLogStatement Logger calls should be surrounded by log level guards. 166
GuardLogStatement Logger calls should be surrounded by log level guards. 189

nl/knaw/dans/bagit/conformance/ManifestChecker.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 98
GuardLogStatement Logger calls should be surrounded by log level guards. 182
GuardLogStatement Logger calls should be surrounded by log level guards. 195
GuardLogStatement Logger calls should be surrounded by log level guards. 219
GuardLogStatement Logger calls should be surrounded by log level guards. 239
GuardLogStatement Logger calls should be surrounded by log level guards. 249
GuardLogStatement Logger calls should be surrounded by log level guards. 259
GuardLogStatement Logger calls should be surrounded by log level guards. 271
GuardLogStatement Logger calls should be surrounded by log level guards. 276
GuardLogStatement Logger calls should be surrounded by log level guards. 312

nl/knaw/dans/bagit/conformance/MetadataChecker.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 65

nl/knaw/dans/bagit/conformance/profile/BagitProfileDeserializer.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 66
GuardLogStatement Logger calls should be surrounded by log level guards. 69
GuardLogStatement Logger calls should be surrounded by log level guards. 83
GuardLogStatement Logger calls should be surrounded by log level guards. 98
GuardLogStatement Logger calls should be surrounded by log level guards. 101
GuardLogStatement Logger calls should be surrounded by log level guards. 105
GuardLogStatement Logger calls should be surrounded by log level guards. 109
GuardLogStatement Logger calls should be surrounded by log level guards. 113
GuardLogStatement Logger calls should be surrounded by log level guards. 124
GuardLogStatement Logger calls should be surrounded by log level guards. 129
GuardLogStatement Logger calls should be surrounded by log level guards. 136
GuardLogStatement Logger calls should be surrounded by log level guards. 143
GuardLogStatement Logger calls should be surrounded by log level guards. 151
GuardLogStatement Logger calls should be surrounded by log level guards. 178
GuardLogStatement Logger calls should be surrounded by log level guards. 194
GuardLogStatement Logger calls should be surrounded by log level guards. 206
GuardLogStatement Logger calls should be surrounded by log level guards. 219
GuardLogStatement Logger calls should be surrounded by log level guards. 233
GuardLogStatement Logger calls should be surrounded by log level guards. 245

nl/knaw/dans/bagit/creator/AbstractCreateManifestsVistor.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 52
GuardLogStatement Logger calls should be surrounded by log level guards. 56
GuardLogStatement Logger calls should be surrounded by log level guards. 66

nl/knaw/dans/bagit/creator/BagCreator.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 137
GuardLogStatement Logger calls should be surrounded by log level guards. 182
GuardLogStatement Logger calls should be surrounded by log level guards. 199
GuardLogStatement Logger calls should be surrounded by log level guards. 206
GuardLogStatement Logger calls should be surrounded by log level guards. 211

nl/knaw/dans/bagit/hash/Hasher.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 94

nl/knaw/dans/bagit/reader/BagitTextFileReader.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 64
GuardLogStatement Logger calls should be surrounded by log level guards. 73
GuardLogStatement Logger calls should be surrounded by log level guards. 77

nl/knaw/dans/bagit/reader/FetchReader.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 61
GuardLogStatement Logger calls should be surrounded by log level guards. 76

nl/knaw/dans/bagit/reader/KeyValueReader.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 73
GuardLogStatement Logger calls should be surrounded by log level guards. 89

nl/knaw/dans/bagit/reader/ManifestReader.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 66
GuardLogStatement Logger calls should be surrounded by log level guards. 73
GuardLogStatement Logger calls should be surrounded by log level guards. 77
GuardLogStatement Logger calls should be surrounded by log level guards. 117

nl/knaw/dans/bagit/reader/MetadataReader.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 54
GuardLogStatement Logger calls should be surrounded by log level guards. 59
GuardLogStatement Logger calls should be surrounded by log level guards. 64

nl/knaw/dans/bagit/verify/AbstractPayloadFileExistsInManifestsVistor.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 46

nl/knaw/dans/bagit/verify/BagVerifier.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 150
GuardLogStatement Logger calls should be surrounded by log level guards. 153
GuardLogStatement Logger calls should be surrounded by log level guards. 158
GuardLogStatement Logger calls should be surrounded by log level guards. 218

nl/knaw/dans/bagit/verify/CheckIfFileExistsTask.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 53
GuardLogStatement Logger calls should be surrounded by log level guards. 82

nl/knaw/dans/bagit/verify/CheckManifestHashesTask.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 68
GuardLogStatement Logger calls should be surrounded by log level guards. 70

nl/knaw/dans/bagit/verify/FileCountAndTotalSizeVistor.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 43
GuardLogStatement Logger calls should be surrounded by log level guards. 54

nl/knaw/dans/bagit/verify/MandatoryVerifier.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 61
GuardLogStatement Logger calls should be surrounded by log level guards. 98
GuardLogStatement Logger calls should be surrounded by log level guards. 125

nl/knaw/dans/bagit/verify/ManifestVerifier.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 133
GuardLogStatement Logger calls should be surrounded by log level guards. 141
GuardLogStatement Logger calls should be surrounded by log level guards. 160
GuardLogStatement Logger calls should be surrounded by log level guards. 178
GuardLogStatement Logger calls should be surrounded by log level guards. 190

nl/knaw/dans/bagit/verify/PayloadFileExistsInAllManifestsVistor.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 50

nl/knaw/dans/bagit/verify/PayloadFileExistsInAtLeastOneManifestVistor.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 45
GuardLogStatement Logger calls should be surrounded by log level guards. 52

nl/knaw/dans/bagit/verify/QuickVerifier.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 55
GuardLogStatement Logger calls should be surrounded by log level guards. 89
GuardLogStatement Logger calls should be surrounded by log level guards. 91
GuardLogStatement Logger calls should be surrounded by log level guards. 97

nl/knaw/dans/bagit/writer/BagWriter.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 59
GuardLogStatement Logger calls should be surrounded by log level guards. 62
GuardLogStatement Logger calls should be surrounded by log level guards. 66
GuardLogStatement Logger calls should be surrounded by log level guards. 69
GuardLogStatement Logger calls should be surrounded by log level guards. 73
GuardLogStatement Logger calls should be surrounded by log level guards. 77
GuardLogStatement Logger calls should be surrounded by log level guards. 81

nl/knaw/dans/bagit/writer/BagitFileWriter.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 53
GuardLogStatement Logger calls should be surrounded by log level guards. 59
GuardLogStatement Logger calls should be surrounded by log level guards. 63

nl/knaw/dans/bagit/writer/FetchWriter.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 54
GuardLogStatement Logger calls should be surrounded by log level guards. 61

nl/knaw/dans/bagit/writer/ManifestWriter.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 55
GuardLogStatement Logger calls should be surrounded by log level guards. 70
GuardLogStatement Logger calls should be surrounded by log level guards. 80
GuardLogStatement Logger calls should be surrounded by log level guards. 91

nl/knaw/dans/bagit/writer/MetadataWriter.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 58
GuardLogStatement Logger calls should be surrounded by log level guards. 68

nl/knaw/dans/bagit/writer/PayloadWriter.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 77
GuardLogStatement Logger calls should be surrounded by log level guards. 85
GuardLogStatement Logger calls should be surrounded by log level guards. 89

Priority 3

nl/knaw/dans/bagit/annotation/Incubating.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Too many lines 22–36
CommentSize Comment is too large: Line too long 25
CommentSize Comment is too large: Line too long 29
CommentSize Comment is too large: Line too long 32

nl/knaw/dans/bagit/conformance/BagLinter.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 16–182
CommentSize Comment is too large: Line too long 58
CommentSize Comment is too large: Line too long 59
CommentRequired Field comments are required 63
CommentRequired Field comments are required 64
CommentRequired Field comments are required 65
CommentSize Comment is too large: Too many lines 71–90
CommentSize Comment is too large: Line too long 73
CommentSize Comment is too large: Line too long 74
CommentSize Comment is too large: Line too long 79
CommentSize Comment is too large: Line too long 80
CommentSize Comment is too large: Line too long 81
CommentSize Comment is too large: Line too long 83
CommentSize Comment is too large: Line too long 84
CommentSize Comment is too large: Line too long 85
CommentSize Comment is too large: Line too long 86
CommentSize Comment is too large: Line too long 87
CommentSize Comment is too large: Line too long 88
CommentSize Comment is too large: Line too long 89
CommentSize Comment is too large: Too many lines 97–112
CommentSize Comment is too large: Line too long 98
CommentSize Comment is too large: Line too long 100
CommentSize Comment is too large: Line too long 107
CommentSize Comment is too large: Line too long 108
CommentSize Comment is too large: Line too long 110
CommentSize Comment is too large: Line too long 111
CommentSize Comment is too large: Too many lines 117–133
CommentSize Comment is too large: Line too long 118
CommentSize Comment is too large: Line too long 120
CommentSize Comment is too large: Line too long 128
CommentSize Comment is too large: Line too long 129
CommentSize Comment is too large: Line too long 131
CommentSize Comment is too large: Line too long 132
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 143
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 151
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 157
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 175

nl/knaw/dans/bagit/conformance/BagProfileChecker.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 16–198
CommentRequired Field comments are required 57
CommentRequired Field comments are required 58
CommentSize Comment is too large: Too many lines 64–83
CommentSize Comment is too large: Line too long 66
CommentSize Comment is too large: Line too long 67
CommentSize Comment is too large: Line too long 73
CommentSize Comment is too large: Line too long 74
CommentSize Comment is too large: Line too long 76
CommentSize Comment is too large: Line too long 77
CommentSize Comment is too large: Line too long 78
CommentSize Comment is too large: Line too long 79
CommentSize Comment is too large: Line too long 80
CommentSize Comment is too large: Line too long 81
CommentSize Comment is too large: Line too long 82
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 91
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 97
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 101
LongVariable Avoid excessively long variable names like bagInfoEntryRequirements 120
LongVariable Avoid excessively long variable names like bagInfoEntryRequirement 123
LongVariable Avoid excessively long variable names like metadataContainsKey 124
LongVariable Avoid excessively long variable names like bagInfoEntryRequirement 134
LongVariable Avoid excessively long variable names like metadataContainsKey 134
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 137
LongVariable Avoid excessively long variable names like bagInfoEntryRequirement 142
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 144
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 144
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 149
LongVariable Avoid excessively long variable names like bagInfoEntryRequirement 155
LongVariable Avoid excessively long variable names like metadataContainsKey 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 157
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 158
LongVariable Avoid excessively long variable names like requiredManifestTypes 164
LongVariable Avoid excessively long variable names like manifestTypesPresent 165
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 169
LongVariable Avoid excessively long variable names like requiredManifestType 172
ShortVariable Avoid variables with short names like sb 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 176
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 179
LongVariable Avoid excessively long variable names like requiredTagFilePaths 187
LongVariable Avoid excessively long variable names like requiredTagFilePath 191

nl/knaw/dans/bagit/conformance/BagitWarning.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 22
CommentSize Comment is too large: Line too long 23
CommentRequired Field comments are required 41
CommentRequired Field comments are required 42
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BagitWarning(String)': enum constructors are implicitly private 44–46
CommentRequired Public method and constructor comments are required 48–50

nl/knaw/dans/bagit/conformance/EncodingChecker.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 29
CommentRequired Field comments are required 32
CommentRequired Field comments are required 33
CommentRequired Public method and constructor comments are required 38–43
LawOfDemeter Potential violation of Law of Demeter (static property access) 39

nl/knaw/dans/bagit/conformance/ManifestChecker.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 52
CommentRequired Field comments are required 53
CommentRequired Field comments are required 55
CommentRequired Field comments are required 56
CommentRequired Field comments are required 57
CommentRequired Field comments are required 58
CommentRequired Field comments are required 59
CommentRequired Field comments are required 60
CommentRequired Field comments are required 61
CommentSize Comment is too large: Too many lines 67–80
CommentSize Comment is too large: Line too long 76
CommentSize Comment is too large: Line too long 77
CommentSize Comment is too large: Line too long 78
CommentSize Comment is too large: Line too long 79
LongVariable Avoid excessively long variable names like missingTagManifest 84
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'files': resource specifications are implicitly final 87
LongVariable Avoid excessively long variable names like missingTagManifest 106
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 108
CommentSize Comment is too large: Line too long 127
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 133
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 143
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 145
DefaultPackage Use explicit scoping instead of the default package private level 160–168
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the parsePath method if you want a default access modifier 160–168
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 162
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 164
CommentSize Comment is too large: Line too long 201
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 206
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 207
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 210
LongVariable Avoid excessively long variable names like normalizedFileToCheck 212
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'files': resource specifications are implicitly final 214
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 218
DefaultPackage Use explicit scoping instead of the default package private level 230–232
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the normalizePathToNFD method if you want a default access modifier 230–232
DefaultPackage Use explicit scoping instead of the default package private level 267–279
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the checkAlgorthm method if you want a default access modifier 267–279
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 270
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 270
DefaultPackage Use explicit scoping instead of the default package private level 281–293
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the checkManifestSets method if you want a default access modifier 281–293
CommentSize Comment is too large: Line too long 289
CommentSize Comment is too large: Line too long 295
DefaultPackage Use explicit scoping instead of the default package private level 296–320
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the checkManifestsListSameSetOfFiles method if you want a default access modifier 297–320
LongVariable Avoid excessively long variable names like compareToManifestPath 301
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 311
DefaultPackage Use explicit scoping instead of the default package private level 323–325
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getOsFilesRegex method if you want a default access modifier 323–325

nl/knaw/dans/bagit/conformance/MetadataChecker.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 37
CommentRequired Field comments are required 38
CommentRequired Public method and constructor comments are required 44–47
LongVariable Avoid excessively long variable names like containsPayloadOxum 56

nl/knaw/dans/bagit/conformance/VersionChecker.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 32
CommentRequired Field comments are required 33
LongVariable Avoid excessively long variable names like LATEST_BAGIT_VERSION 33
CommentRequired Field comments are required 34
CommentRequired Public method and constructor comments are required 39–44

nl/knaw/dans/bagit/conformance/profile/BagInfoRequirement.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 23
DataClass The class 'BagInfoRequirement' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=6, WMC=13) 25–94
CommentRequired Field comments are required 26
CommentRequired Field comments are required 27
CommentRequired Field comments are required 28
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 33
CommentRequired Public method and constructor comments are required 46–48
CommentSize Comment is too large: Line too long 50

nl/knaw/dans/bagit/conformance/profile/BagitProfile.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 26
AtLeastOneConstructor Each class should declare at least one constructor 28–174
DataClass The class 'BagitProfile' is suspected to be a Data Class (WOC=9.091%, NOPA=0, NOAM=30, WMC=34) 28–174
LongVariable Avoid excessively long variable names like bagitProfileIdentifier 29
CommentRequired Field comments are required 29
LongVariable Avoid excessively long variable names like sourceOrganization 30
CommentRequired Field comments are required 30
LongVariable Avoid excessively long variable names like externalDescription 31
CommentRequired Field comments are required 31
CommentRequired Field comments are required 32
CommentRequired Field comments are required 33
CommentRequired Field comments are required 34
CommentRequired Field comments are required 35
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 37
LongVariable Avoid excessively long variable names like bagInfoRequirements 37
CommentRequired Field comments are required 37
CommentRequired Field comments are required 38
LongVariable Avoid excessively long variable names like manifestTypesRequired 38
CommentRequired Field comments are required 39
CommentRequired Field comments are required 40
LongVariable Avoid excessively long variable names like acceptableMIMESerializationTypes 41
CommentRequired Field comments are required 41
CommentRequired Field comments are required 42
LongVariable Avoid excessively long variable names like acceptableBagitVersions 42
LongVariable Avoid excessively long variable names like tagManifestTypesRequired 43
CommentRequired Field comments are required 43
CommentRequired Field comments are required 44
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 50
LongVariable Avoid excessively long variable names like acceptSerialization 111
LongVariable Avoid excessively long variable names like acceptBagitVersion 117
LongVariable Avoid excessively long variable names like tagManifestsRequired 123
LongVariable Avoid excessively long variable names like bagitProfileIdentifier 135
LongVariable Avoid excessively long variable names like sourceOrganization 141
LongVariable Avoid excessively long variable names like externalDescription 147

nl/knaw/dans/bagit/conformance/profile/BagitProfileDeserializer.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 42
CommentRequired Field comments are required 43
CommentRequired Public method and constructor comments are required 45–47
ShortVariable Avoid variables with short names like vc 49
CommentRequired Public method and constructor comments are required 49–51
ShortVariable Avoid variables with short names like p 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 57
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 68
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 68
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 71
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
LongVariable Avoid excessively long variable names like bagitProfileInfoNode 85
CommentSize Comment is too large: Line too long 91
LongVariable Avoid excessively long variable names like bagitProfileInfoNode 97
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 108
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
CommentSize Comment is too large: Line too long 118
LongVariable Avoid excessively long variable names like bagitProfileInfoNode 123
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 152
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 161
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 161
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 163
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 169
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 173
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 173
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 175
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 179
LongVariable Avoid excessively long variable names like serialiationFormats 200
LongVariable Avoid excessively long variable names like serialiationFormat 203
LongVariable Avoid excessively long variable names like tagManifestsRequiredNodes 212
LongVariable Avoid excessively long variable names like requiredTagmanifestTypes 213
LongVariable Avoid excessively long variable names like tagManifestsRequiredNode 215
LongVariable Avoid excessively long variable names like tagFilesRequiredNodes 225
LongVariable Avoid excessively long variable names like tagFilesRequiredNode 229
LongVariable Avoid excessively long variable names like acceptableVersionsNodes 239
LongVariable Avoid excessively long variable names like acceptableVersions 240
LongVariable Avoid excessively long variable names like acceptableVersionsNode 242

nl/knaw/dans/bagit/conformance/profile/Serialization.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2

nl/knaw/dans/bagit/creator/AbstractCreateManifestsVistor.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 35
CommentRequired Field comments are required 39
CommentRequired Field comments are required 40
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 42
CommentRequired Field comments are required 42
LongVariable Avoid excessively long variable names like includeHiddenFiles 43
CommentRequired Field comments are required 43
CommentRequired Public method and constructor comments are required 45–48
LongVariable Avoid excessively long variable names like includeHiddenFiles 45
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 45
CallSuperInConstructor It is a good practice to call super() in a constructor 45–48
CommentRequired Public method and constructor comments are required 50–61
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 53
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 57

nl/knaw/dans/bagit/creator/BagCreator.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 51
CommentRequired Field comments are required 52
CommentRequired Field comments are required 53
CommentRequired Field comments are required 54
LongVariable Avoid excessively long variable names like LATEST_NON_DOT_BAGIT_VERSION 55
CommentRequired Field comments are required 55
CommentSize Comment is too large: Too many lines 59–72
CommentSize Comment is too large: Line too long 61
CommentSize Comment is too large: Line too long 64
CommentSize Comment is too large: Line too long 66
CommentSize Comment is too large: Line too long 68
CommentSize Comment is too large: Too many lines 77–91
CommentSize Comment is too large: Line too long 79
CommentSize Comment is too large: Line too long 82
CommentSize Comment is too large: Line too long 84
CommentSize Comment is too large: Line too long 85
CommentSize Comment is too large: Line too long 87
CommentSize Comment is too large: Too many lines 96–109
CommentSize Comment is too large: Line too long 98
CommentSize Comment is too large: Line too long 101
CommentSize Comment is too large: Line too long 103
CommentSize Comment is too large: Line too long 105
CommentSize Comment is too large: Too many lines 115–129
CommentSize Comment is too large: Line too long 117
CommentSize Comment is too large: Line too long 120
CommentSize Comment is too large: Line too long 122
CommentSize Comment is too large: Line too long 123
CommentSize Comment is too large: Line too long 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 161
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'directoryStream': resource specifications are implicitly final 171
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 192
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 192
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 201
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 203
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 222
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 222

nl/knaw/dans/bagit/creator/CreatePayloadManifestsVistor.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 28
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 33
LongVariable Avoid excessively long variable names like includeHiddenFiles 33
CommentRequired Public method and constructor comments are required 33–35

nl/knaw/dans/bagit/creator/CreateTagManifestsVistor.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 28
LongVariable Avoid excessively long variable names like includeHiddenFiles 33
CommentRequired Public method and constructor comments are required 33–35
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 33

nl/knaw/dans/bagit/domain/Bag.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
DataClass The class 'Bag' is suspected to be a Data Class (WOC=15.000%, NOPA=0, NOAM=14, WMC=25) 30–184
CommentRequired Field comments are required 32
CommentRequired Field comments are required 35
CommentRequired Field comments are required 38
CommentRequired Field comments are required 41
CommentRequired Field comments are required 44
CommentRequired Field comments are required 47
CommentRequired Field comments are required 50
ShortVariable Avoid variables with short names like sb 129
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 155
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 158
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 161
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 165
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 166
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 167
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 168
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 169
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 170

nl/knaw/dans/bagit/domain/FetchItem.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 24
CommentRequired Field comments are required 42
ShortVariable Avoid variables with short names like sb 57
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 101
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 104
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 107
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 112

nl/knaw/dans/bagit/domain/Manifest.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 26
CommentRequired Field comments are required 29
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 30
CommentRequired Field comments are required 30
CommentRequired Public method and constructor comments are required 32–34
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 61
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 64
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 67
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 72

nl/knaw/dans/bagit/domain/Metadata.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
AtLeastOneConstructor Each class should declare at least one constructor 30–179
CommentRequired Field comments are required 31
CommentRequired Field comments are required 32
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 32
CommentRequired Field comments are required 33
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 47
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 48
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 49
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 92
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 121
CommentSize Comment is too large: Line too long 136

nl/knaw/dans/bagit/domain/Version.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 24
CommentRequired Field comments are required 25
CommentRequired Field comments are required 27
CommentRequired Public method and constructor comments are required 29–33
CommentRequired Public method and constructor comments are required 35–37
ShortVariable Avoid variables with short names like o 45
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 50
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 53
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 67
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 70
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 73
CommentRequired Public method and constructor comments are required 81–83
CommentRequired Public method and constructor comments are required 85–87
CommentRequired Public method and constructor comments are required 89–91
CommentRequired Public method and constructor comments are required 93–95

nl/knaw/dans/bagit/exceptions/CorruptChecksumException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 23
CommentRequired Public method and constructor comments are required 28–30

nl/knaw/dans/bagit/exceptions/FileNotInManifestException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 21
CommentRequired Public method and constructor comments are required 27–29

nl/knaw/dans/bagit/exceptions/FileNotInPayloadDirectoryException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 19
CommentRequired Public method and constructor comments are required 25–27

nl/knaw/dans/bagit/exceptions/InvalidBagMetadataException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 19
CommentRequired Public method and constructor comments are required 29–31

nl/knaw/dans/bagit/exceptions/InvalidBagitFileFormatException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 19
CommentRequired Public method and constructor comments are required 24–26
ShortVariable Avoid variables with short names like e 28
CommentRequired Public method and constructor comments are required 28–30

nl/knaw/dans/bagit/exceptions/InvalidPayloadOxumException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 19
CommentRequired Public method and constructor comments are required 25–27

nl/knaw/dans/bagit/exceptions/MaliciousPathException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 19
CommentSize Comment is too large: Line too long 20
CommentRequired Public method and constructor comments are required 25–27

nl/knaw/dans/bagit/exceptions/MissingBagitFileException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 19
CommentRequired Public method and constructor comments are required 24–26

nl/knaw/dans/bagit/exceptions/MissingPayloadDirectoryException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 23
CommentRequired Public method and constructor comments are required 28–30

nl/knaw/dans/bagit/exceptions/MissingPayloadManifestException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 19
CommentRequired Public method and constructor comments are required 24–26

nl/knaw/dans/bagit/exceptions/PayloadOxumDoesNotExistException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 21
CommentSize Comment is too large: Line too long 22
CommentRequired Public method and constructor comments are required 27–29

nl/knaw/dans/bagit/exceptions/UnparsableVersionException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 21
CommentRequired Public method and constructor comments are required 26–28

nl/knaw/dans/bagit/exceptions/UnsupportedAlgorithmException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 23
LongVariable Avoid excessively long variable names like bagitAlgorithmName 28
CommentRequired Public method and constructor comments are required 28–30

nl/knaw/dans/bagit/exceptions/VerificationException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Public method and constructor comments are required 24–26

nl/knaw/dans/bagit/exceptions/conformance/BagitVersionIsNotAcceptableException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 24
CommentRequired Public method and constructor comments are required 29–31
LongVariable Avoid excessively long variable names like acceptableVersions 29

nl/knaw/dans/bagit/exceptions/conformance/FetchFileNotAllowedException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 23
CommentRequired Public method and constructor comments are required 28–30

nl/knaw/dans/bagit/exceptions/conformance/MetatdataValueIsNotAcceptableException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 23
CommentRequired Public method and constructor comments are required 28–30

nl/knaw/dans/bagit/exceptions/conformance/MetatdataValueIsNotRepeatableException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Public method and constructor comments are required 26–28

nl/knaw/dans/bagit/exceptions/conformance/RequiredManifestNotPresentException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 19
CommentRequired Public method and constructor comments are required 24–26

nl/knaw/dans/bagit/exceptions/conformance/RequiredMetadataFieldNotPresentException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Public method and constructor comments are required 26–28
LongVariable Avoid excessively long variable names like bagInfoEntryRequirementKey 26

nl/knaw/dans/bagit/exceptions/conformance/RequiredTagFileNotPresentException.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Public method and constructor comments are required 26–28
LongVariable Avoid excessively long variable names like requiredTagFilePath 26

nl/knaw/dans/bagit/hash/BagitAlgorithmNameToSupportedAlgorithmMapping.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 21
LongVariable Avoid excessively long variable names like bagitAlgorithmName 24
CommentRequired Public method and constructor comments are required 24

nl/knaw/dans/bagit/hash/Hasher.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 42
CommentRequired Field comments are required 43
CommentRequired Field comments are required 44
CommentRequired Field comments are required 45
CommentSize Comment is too large: Line too long 55
CommentSize Comment is too large: Line too long 69
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 72
DefaultPackage Use explicit scoping instead of the default package private level 77–89
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the updateMessageDigests method if you want a default access modifier 77–89
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'is': resource specifications are implicitly final 78
ShortVariable Avoid variables with short names like is 78
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 91
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 95
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'formatter': resource specifications are implicitly final 101
CommentSize Comment is too large: Line too long 111
CommentSize Comment is too large: Line too long 113
CommentSize Comment is too large: Line too long 115
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 119

nl/knaw/dans/bagit/hash/StandardBagitAlgorithmNameToSupportedAlgorithmMapping.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
AtLeastOneConstructor Each class should declare at least one constructor 26–39
CommentRequired Field comments are required 28
LongVariable Avoid excessively long variable names like bagitAlgorithmName 31

nl/knaw/dans/bagit/hash/StandardSupportedAlgorithms.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 28
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StandardSupportedAlgorithms(String)': enum constructors are implicitly private 30–32
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 42

nl/knaw/dans/bagit/hash/SupportedAlgorithm.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Public method and constructor comments are required 25
CommentRequired Public method and constructor comments are required 26

nl/knaw/dans/bagit/reader/BagReader.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 38
CommentRequired Public method and constructor comments are required 40–42
CommentRequired Public method and constructor comments are required 44–46
CommentSize Comment is too large: Too many lines 48–60
CommentSize Comment is too large: Line too long 55
CommentSize Comment is too large: Line too long 56
CommentSize Comment is too large: Line too long 57
CommentSize Comment is too large: Line too long 58
CommentSize Comment is too large: Line too long 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 71
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 73
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 78
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 82

nl/knaw/dans/bagit/reader/BagitTextFileReader.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 38
CommentRequired Field comments are required 41
UseShortArrayInitializer Array initialization can be written shorter 42
CommentRequired Field comments are required 42
CommentRequired Field comments are required 43
CommentRequired Field comments are required 44
CommentRequired Field comments are required 45
CommentRequired Field comments are required 46
CommentSize Comment is too large: Too many lines 52–62
CommentSize Comment is too large: Line too long 58
CommentSize Comment is too large: Line too long 59
CommentSize Comment is too large: Line too long 60
CommentSize Comment is too large: Line too long 61
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 86
LongVariable Avoid excessively long variable names like firstFewBytesInFile 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
CommentSize Comment is too large: Line too long 106
DefaultPackage Use explicit scoping instead of the default package private level 110–124
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the throwErrorIfLinesDoNotMatchStrict method if you want a default access modifier 110–124
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 111
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113–114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 117–118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 120
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 121–122
CommentRequired Public method and constructor comments are required 129–143
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 134

nl/knaw/dans/bagit/reader/FetchReader.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 36
CommentRequired Field comments are required 39
CommentRequired Field comments are required 40
CommentRequired Field comments are required 41
CommentSize Comment is too large: Too many lines 47–58
CommentSize Comment is too large: Line too long 56
CommentSize Comment is too large: Line too long 57
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 64
UnusedAssignment The initializer for variable 'parts' is never used (overwritten on line 71) 66
UnusedAssignment The initializer for variable 'length' is never used (overwritten on line 73) 67
UnusedAssignment The initializer for variable 'url' is never used (overwritten on line 74) 68
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 70
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 70
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 71
LiteralsFirstInComparisons Position literals first in String comparisons 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81

nl/knaw/dans/bagit/reader/KeyValueReader.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 38
LongVariable Avoid excessively long variable names like INDENTED_LINE_REGEX 39
CommentRequired Field comments are required 39
CommentRequired Field comments are required 40
CommentSize Comment is too large: Too many lines 47–58
CommentSize Comment is too large: Line too long 48
CommentSize Comment is too large: Line too long 57
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 66
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 86
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 86
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 97

nl/knaw/dans/bagit/reader/ManifestReader.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 42
CommentRequired Field comments are required 45
CommentRequired Field comments are required 46
CommentSize Comment is too large: Too many lines 52–64
CommentSize Comment is too large: Line too long 53
CommentSize Comment is too large: Line too long 55
CommentSize Comment is too large: Line too long 61
CommentSize Comment is too large: Line too long 62
CommentSize Comment is too large: Line too long 63
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the readAllManifests method if you want a default access modifier 65–82
DefaultPackage Use explicit scoping instead of the default package private level 65–82
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'manifests': resource specifications are implicitly final 68
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 72
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 78
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 91
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 93
CommentSize Comment is too large: Too many lines 100–113
CommentSize Comment is too large: Line too long 103
CommentSize Comment is too large: Line too long 110
CommentSize Comment is too large: Line too long 111
CommentSize Comment is too large: Line too long 112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 118
LongVariable Avoid excessively long variable names like filetToChecksumMap 123
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the readChecksumFileMap method if you want a default access modifier 132–146
DefaultPackage Use explicit scoping instead of the default package private level 132–146
ShortVariable Avoid variables with short names like br 134
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'br': resource specifications are implicitly final 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 137

nl/knaw/dans/bagit/reader/MetadataReader.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 33
CommentRequired Field comments are required 36
CommentRequired Field comments are required 37
CommentSize Comment is too large: Too many lines 43–52
CommentSize Comment is too large: Line too long 51

nl/knaw/dans/bagit/reader/TagFileReader.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 36
CommentRequired Field comments are required 37
CommentRequired Field comments are required 38
CommentSize Comment is too large: Line too long 41
CommentRequired Public method and constructor comments are required 43–80
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 45
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 57
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 62
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 67
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 71
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 76

nl/knaw/dans/bagit/util/PathUtils.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 31
LongVariable Avoid excessively long variable names like DOT_BAGIT_DIR_NAME 34
CommentRequired Field comments are required 34
CommentSize Comment is too large: Line too long 41
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 51
CommentSize Comment is too large: Line too long 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 64
CommentSize Comment is too large: Line too long 68
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 73
CommentSize Comment is too large: Line too long 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 86
CommentSize Comment is too large: Line too long 94
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105
CommentSize Comment is too large: Too many lines 108–117
CommentSize Comment is too large: Line too long 110
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 120
CommentSize Comment is too large: Line too long 127
CommentSize Comment is too large: Line too long 128
CommentSize Comment is too large: Line too long 132
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 136
CommentSize Comment is too large: Too many lines 142–150
CommentSize Comment is too large: Line too long 143
CommentSize Comment is too large: Line too long 144
CommentSize Comment is too large: Line too long 149
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 153
CommentSize Comment is too large: Too many lines 159–167

nl/knaw/dans/bagit/verify/AbstractPayloadFileExistsInManifestsVistor.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 32
CommentRequired Field comments are required 35
CommentRequired Field comments are required 36
CommentRequired Field comments are required 37
CallSuperInConstructor It is a good practice to call super() in a constructor 39–41
CommentRequired Public method and constructor comments are required 39–41
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 47

nl/knaw/dans/bagit/verify/BagVerifier.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 52
CommentRequired Field comments are required 53
CommentRequired Field comments are required 55
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 56
CommentRequired Field comments are required 56
CommentSize Comment is too large: Line too long 69
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 81
CommentSize Comment is too large: Line too long 88
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 91
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 97
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 99
CommentSize Comment is too large: Line too long 104
CommentSize Comment is too large: Too many lines 113–123
CommentSize Comment is too large: Line too long 114
CommentSize Comment is too large: Line too long 119
CommentSize Comment is too large: Line too long 120
CommentSize Comment is too large: Line too long 121
CommentSize Comment is too large: Too many lines 128–148
CommentSize Comment is too large: Line too long 129
CommentSize Comment is too large: Line too long 134
CommentSize Comment is too large: Line too long 136
CommentSize Comment is too large: Line too long 138
CommentSize Comment is too large: Line too long 139
CommentSize Comment is too large: Line too long 142
CommentSize Comment is too large: Line too long 143
CommentSize Comment is too large: Line too long 144
CommentSize Comment is too large: Line too long 145
CommentSize Comment is too large: Line too long 146
CommentSize Comment is too large: Line too long 147
DefaultPackage Use explicit scoping instead of the default package private level 167–189
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the checkHashes method if you want a default access modifier 168–189
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 169
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 174
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 175
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 175
ShortVariable Avoid variables with short names like e 181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 181
CommentSize Comment is too large: Too many lines 191–214
CommentSize Comment is too large: Line too long 192
CommentSize Comment is too large: Line too long 197
CommentSize Comment is too large: Line too long 198
CommentSize Comment is too large: Line too long 203
CommentSize Comment is too large: Line too long 206
CommentSize Comment is too large: Line too long 209
CommentSize Comment is too large: Line too long 210
CommentSize Comment is too large: Line too long 211
CommentSize Comment is too large: Line too long 212
CommentSize Comment is too large: Line too long 213
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 231

nl/knaw/dans/bagit/verify/CheckIfFileExistsTask.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 31
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 33
CommentRequired Field comments are required 35
CommentRequired Field comments are required 36
CommentRequired Field comments are required 37
CommentRequired Field comments are required 38
CommentRequired Field comments are required 39
CommentRequired Public method and constructor comments are required 41–45
CommentSize Comment is too large: Line too long 64
CommentSize Comment is too large: Line too long 65
CommentSize Comment is too large: Line too long 67
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'files': resource specifications are implicitly final 73
LongVariable Avoid excessively long variable names like normalizedFileToCheck 75
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 77

nl/knaw/dans/bagit/verify/CheckManifestHashesTask.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 35
CommentRequired Field comments are required 40
CommentRequired Field comments are required 41
CommentRequired Field comments are required 43
CommentRequired Field comments are required 44
CommentRequired Field comments are required 45
CommentRequired Field comments are required 46
CommentRequired Public method and constructor comments are required 48–53
CommentRequired Protected method constructor comments are required 66–76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 71
CommentSize Comment is too large: Line too long 75

nl/knaw/dans/bagit/verify/FileCountAndTotalSizeVistor.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 31
AtLeastOneConstructor Each class should declare at least one constructor 33–67
CommentRequired Field comments are required 34
CommentRequired Field comments are required 35
CommentRequired Field comments are required 37
CommentRequired Field comments are required 38
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 44

nl/knaw/dans/bagit/verify/MandatoryVerifier.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 40
CommentRequired Field comments are required 43
CommentRequired Field comments are required 44
LongVariable Avoid excessively long variable names like DOT_BAGIT_DIR_NAME 47
CommentRequired Field comments are required 47
CommentSize Comment is too large: Line too long 58
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 65
CommentSize Comment is too large: Line too long 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 87
CommentSize Comment is too large: Line too long 95
CommentSize Comment is too large: Too many lines 109–117
CommentSize Comment is too large: Line too long 115
LongVariable Avoid excessively long variable names like hasAtLeastOneManifest 120
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 124

nl/knaw/dans/bagit/verify/ManifestVerifier.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 50
CommentRequired Field comments are required 51
CommentRequired Field comments are required 53
CommentRequired Field comments are required 54
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 54
CommentSize Comment is too large: Line too long 67
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 79
CommentSize Comment is too large: Line too long 86
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 89
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 95
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 97
CommentSize Comment is too large: Too many lines 100–113
CommentSize Comment is too large: Line too long 101
CommentSize Comment is too large: Line too long 105
CommentSize Comment is too large: Line too long 108
CommentSize Comment is too large: Line too long 109
CommentSize Comment is too large: Line too long 110
CommentSize Comment is too large: Line too long 111
LongVariable Avoid excessively long variable names like allFilesListedInManifests 118
LongVariable Avoid excessively long variable names like filesListedInManifests 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 140
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 140
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 144
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 144
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 162
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 169
LongVariable Avoid excessively long variable names like filesListedInManifests 176

nl/knaw/dans/bagit/verify/PayloadFileExistsInAllManifestsVistor.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 30
CommentRequired Field comments are required 33
CommentRequired Public method and constructor comments are required 35–38
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 44
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 44
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 46
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 46

nl/knaw/dans/bagit/verify/PayloadFileExistsInAtLeastOneManifestVistor.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 31
CommentRequired Field comments are required 34
CommentRequired Field comments are required 35
LongVariable Avoid excessively long variable names like filesListedInManifests 35
CommentRequired Public method and constructor comments are required 37–40
LongVariable Avoid excessively long variable names like filesListedInManifests 37
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 50

nl/knaw/dans/bagit/verify/QuickVerifier.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 34
CommentSize Comment is too large: Line too long 35
CommentRequired Field comments are required 39
CommentRequired Field comments are required 40
LongVariable Avoid excessively long variable names like PAYLOAD_OXUM_REGEX 41
CommentRequired Field comments are required 41
CommentSize Comment is too large: Line too long 48
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 63
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 65
CommentSize Comment is too large: Too many lines 71–81
CommentSize Comment is too large: Line too long 72
CommentSize Comment is too large: Line too long 77
CommentSize Comment is too large: Line too long 78
CommentSize Comment is too large: Line too long 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 84
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 88
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 92
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105

nl/knaw/dans/bagit/writer/BagWriter.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 39
CommentRequired Field comments are required 40
CommentSize Comment is too large: Too many lines 46–57
CommentSize Comment is too large: Line too long 48
CommentSize Comment is too large: Line too long 49
CommentSize Comment is too large: Line too long 50
CommentSize Comment is too large: Line too long 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 72
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 80
LongVariable Avoid excessively long variable names like updatedTagManifests 83
CommentSize Comment is too large: Line too long 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 118
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 121

nl/knaw/dans/bagit/writer/BagitFileWriter.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 35
CommentRequired Field comments are required 36
CommentSize Comment is too large: Too many lines 42–50

nl/knaw/dans/bagit/writer/FetchWriter.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 33
CommentRequired Field comments are required 36
CommentRequired Field comments are required 37
CommentSize Comment is too large: Too many lines 43–52
CommentSize Comment is too large: Line too long 44
ShortVariable Avoid variables with short names like sb 68

nl/knaw/dans/bagit/writer/ManifestWriter.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 37
CommentRequired Field comments are required 38
CommentSize Comment is too large: Too many lines 44–53
CommentSize Comment is too large: Too many lines 59–68
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 79
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 87
CommentSize Comment is too large: Line too long 88
CommentSize Comment is too large: Line too long 89

nl/knaw/dans/bagit/writer/MetadataWriter.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 35
CommentRequired Field comments are required 36
CommentRequired Field comments are required 37
CommentSize Comment is too large: Too many lines 43–52
CommentSize Comment is too large: Line too long 44
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 58

nl/knaw/dans/bagit/writer/PayloadWriter.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentRequired Field comments are required 38
CommentRequired Field comments are required 39
CommentRequired Field comments are required 40
CommentSize Comment is too large: Line too long 47
DefaultPackage Use explicit scoping instead of the default package private level 49–64
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the writeVersionDependentPayloadFiles method if you want a default access modifier 49–64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 60
CommentSize Comment is too large: Too many lines 66–75
CommentSize Comment is too large: Line too long 70
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
LongVariable Avoid excessively long variable names like relativePayloadPath 82
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 84
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 105

nl/knaw/dans/bagit/writer/RelativePathWriter.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 1–15
CommentSize Comment is too large: Line too long 2
CommentSize Comment is too large: Line too long 32
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 40
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 41

Priority 4

nl/knaw/dans/bagit/domain/Bag.java

Rule Violation Line
ShortClassName Avoid short class names like Bag 30–184

Priority 5

nl/knaw/dans/bagit/conformance/BagLinter.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 176
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 176

nl/knaw/dans/bagit/conformance/BagProfileChecker.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 114
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 114
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 135
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 135
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 145
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 145
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'manifestTypesPresent' (lines '165'-'185'). 165–185

nl/knaw/dans/bagit/conformance/EncodingChecker.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 40
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 40

nl/knaw/dans/bagit/conformance/ManifestChecker.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'payloadManifests' (lines '85'-'101'). 85–101
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'tagManifests' (lines '86'-'101'). 86–101
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 98
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 98
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'missingTagManifest' (lines '106'-'116'). 106–116
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paths' (lines '134'-'155'). 134–155
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fixedPath' (lines '174'-'178'). 174–178
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 182
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 182
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 195
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 195
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'normalizedFileToCheck' (lines '212'-'225'). 212–225
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 219
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 219
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 249
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 249
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 259
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 259
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 271
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 271
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 276
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 276
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'nameMapping' (lines '298'-'320'). 298–320
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'compareToManifest' (lines '300'-'320'). 300–320
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'compareToManifestPath' (lines '301'-'320'). 301–320
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'compareToManifestPath' (lines '301'-'306'). 301–306
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'compareToManifestPath' (lines '306'-'306'). 306
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'compareToManifestPath' (lines '306'-'320'). 306–320
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 312
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 312

nl/knaw/dans/bagit/conformance/MetadataChecker.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'containsPayloadOxum' (lines '56'-'60'). 56–60
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'containsPayloadOxum' (lines '60'-'60'). 60

nl/knaw/dans/bagit/conformance/VersionChecker.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 41
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 41

nl/knaw/dans/bagit/conformance/profile/BagitProfileDeserializer.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 66
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 66
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 69
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 69
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 101
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 101
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 105
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 105
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 109
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 109
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 113
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 113
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 129
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 129
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 136
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 136
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 143
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 143
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 194
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 194
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 206
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 206
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 219
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 219
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 233
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 233
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 245
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 245

nl/knaw/dans/bagit/creator/AbstractCreateManifestsVistor.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 52
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 52
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 56
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 56
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 66
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 66

nl/knaw/dans/bagit/creator/BagCreator.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 137
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 137
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 199
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 199

nl/knaw/dans/bagit/domain/Metadata.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'entryToRemove' (lines '143'-'146'). 143–146
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'entryToRemove' (lines '146'-'146'). 146

nl/knaw/dans/bagit/hash/Hasher.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 94
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 94

nl/knaw/dans/bagit/reader/BagitTextFileReader.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 64
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 64
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'version' (lines '68'-'72'). 68–72
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'encoding' (lines '69'-'76'). 69–76
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 73
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 73
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 77
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 77

nl/knaw/dans/bagit/reader/FetchReader.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 61
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 61
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'itemsToFetch' (lines '62'-'89'). 62–89
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'parts' (lines '66'-'71'). 66–71
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'parts' (lines '66'-'89'). 66–89
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'length' (lines '67'-'89'). 67–89
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'length' (lines '67'-'73'). 67–73
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'url' (lines '68'-'89'). 68–89
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'url' (lines '68'-'74'). 68–74
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 4 76
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 4 76

nl/knaw/dans/bagit/reader/KeyValueReader.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 4 73
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 4 73
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 89
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 89

nl/knaw/dans/bagit/reader/ManifestReader.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 73
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 73
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 77
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 77
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'filter' (lines '88'-'98'). 88–98
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'filter' (lines '88'-'98'). 88–98
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 117
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 117

nl/knaw/dans/bagit/reader/MetadataReader.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'metadata' (lines '55'-'60'). 55–60
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'metadata' (lines '55'-'65'). 55–65
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 59
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 59
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'metadata' (lines '60'-'65'). 60–65
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 64
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 64

nl/knaw/dans/bagit/reader/TagFileReader.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'fixedPath' (lines '44'-'80'). 44–80
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fixedPath' (lines '44'-'47'). 44–47
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'fixedPath' (lines '47'-'80'). 47–80
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'file' (lines '64'-'80'). 64–80

nl/knaw/dans/bagit/util/PathUtils.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'filename' (lines '47'-'51'). 47–51

nl/knaw/dans/bagit/verify/AbstractPayloadFileExistsInManifestsVistor.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 46
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 46

nl/knaw/dans/bagit/verify/BagVerifier.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 150
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 150
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 183
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 183
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 218
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 218

nl/knaw/dans/bagit/verify/CheckIfFileExistsTask.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 53
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 53
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'normalizedFile' (lines '70'-'87'). 70–87
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 82
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 82

nl/knaw/dans/bagit/verify/CheckManifestHashesTask.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 68
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 68

nl/knaw/dans/bagit/verify/FileCountAndTotalSizeVistor.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 43
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 43
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 54
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 54

nl/knaw/dans/bagit/verify/MandatoryVerifier.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 61
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 61
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'bagitFile' (lines '79'-'82'). 79–82
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'hasAtLeastOneManifest' (lines '120'-'126'). 120–126
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 125
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 125
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'hasAtLeastOneManifest' (lines '126'-'126'). 126

nl/knaw/dans/bagit/verify/ManifestVerifier.java

Rule Violation Line
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 141
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 141
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 178
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 178
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 190
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 190

nl/knaw/dans/bagit/verify/QuickVerifier.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 55
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 55
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 89
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 89
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 91
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 91
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'numberOfFiles' (lines '92'-'107'). 92–107
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 4 97
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 4 97

nl/knaw/dans/bagit/writer/BagitFileWriter.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 53
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 53
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 59
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 59
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 63
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 63

nl/knaw/dans/bagit/writer/FetchWriter.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 54
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 54
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'fetchFilePath' (lines '55'-'65'). 55–65
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 61
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 61

nl/knaw/dans/bagit/writer/ManifestWriter.java

Rule Violation Line
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 80
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 80
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 91
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 91

nl/knaw/dans/bagit/writer/MetadataWriter.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'bagInfoFilePath' (lines '54'-'56'). 54–56
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 58
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 58
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 68
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 68

nl/knaw/dans/bagit/writer/PayloadWriter.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'bagitDir' (lines '50'-'53'). 50–53
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'fetchPaths' (lines '78'-'98'). 78–98
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 85
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 85
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 89
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 89

Files

nl/knaw/dans/bagit/annotation/Incubating.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Too many lines 3 22–36
CommentSize Comment is too large: Line too long 3 25
CommentSize Comment is too large: Line too long 3 29
CommentSize Comment is too large: Line too long 3 32

nl/knaw/dans/bagit/conformance/BagLinter.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 16–182
CommentSize Comment is too large: Line too long 3 58
CommentSize Comment is too large: Line too long 3 59
CommentRequired Field comments are required 3 63
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 63
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 63
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 64
CommentRequired Field comments are required 3 64
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 64
CommentRequired Field comments are required 3 65
CommentSize Comment is too large: Too many lines 3 71–90
CommentSize Comment is too large: Line too long 3 73
CommentSize Comment is too large: Line too long 3 74
CommentSize Comment is too large: Line too long 3 79
CommentSize Comment is too large: Line too long 3 80
CommentSize Comment is too large: Line too long 3 81
CommentSize Comment is too large: Line too long 3 83
CommentSize Comment is too large: Line too long 3 84
CommentSize Comment is too large: Line too long 3 85
CommentSize Comment is too large: Line too long 3 86
CommentSize Comment is too large: Line too long 3 87
CommentSize Comment is too large: Line too long 3 88
CommentSize Comment is too large: Line too long 3 89
CommentSize Comment is too large: Too many lines 3 97–112
CommentSize Comment is too large: Line too long 3 98
CommentSize Comment is too large: Line too long 3 100
CommentSize Comment is too large: Line too long 3 107
CommentSize Comment is too large: Line too long 3 108
CommentSize Comment is too large: Line too long 3 110
CommentSize Comment is too large: Line too long 3 111
CommentSize Comment is too large: Too many lines 3 117–133
CommentSize Comment is too large: Line too long 3 118
CommentSize Comment is too large: Line too long 3 120
CommentSize Comment is too large: Line too long 3 128
CommentSize Comment is too large: Line too long 3 129
CommentSize Comment is too large: Line too long 3 131
CommentSize Comment is too large: Line too long 3 132
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 143
GuardLogStatement Logger calls should be surrounded by log level guards. 2 147
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 148
GuardLogStatement Logger calls should be surrounded by log level guards. 2 150
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 151
GuardLogStatement Logger calls should be surrounded by log level guards. 2 153
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
GuardLogStatement Logger calls should be surrounded by log level guards. 2 156
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 157
GuardLogStatement Logger calls should be surrounded by log level guards. 2 164
GuardLogStatement Logger calls should be surrounded by log level guards. 2 168
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 175
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 176
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 176
GuardLogStatement Logger calls should be surrounded by log level guards. 2 176

nl/knaw/dans/bagit/conformance/BagProfileChecker.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 16–198
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 57
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 57
CommentRequired Field comments are required 3 57
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 58
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 58
CommentRequired Field comments are required 3 58
CommentSize Comment is too large: Too many lines 3 64–83
CommentSize Comment is too large: Line too long 3 66
CommentSize Comment is too large: Line too long 3 67
CommentSize Comment is too large: Line too long 3 73
CommentSize Comment is too large: Line too long 3 74
CommentSize Comment is too large: Line too long 3 76
CommentSize Comment is too large: Line too long 3 77
CommentSize Comment is too large: Line too long 3 78
CommentSize Comment is too large: Line too long 3 79
CommentSize Comment is too large: Line too long 3 80
CommentSize Comment is too large: Line too long 3 81
CommentSize Comment is too large: Line too long 3 82
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 91
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 97
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 101
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 114
GuardLogStatement Logger calls should be surrounded by log level guards. 2 114
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 114
LongVariable Avoid excessively long variable names like bagInfoEntryRequirements 3 120
LongVariable Avoid excessively long variable names like bagInfoEntryRequirement 3 123
LongVariable Avoid excessively long variable names like metadataContainsKey 3 124
LongVariable Avoid excessively long variable names like bagInfoEntryRequirement 3 134
LongVariable Avoid excessively long variable names like metadataContainsKey 3 134
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 135
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 135
GuardLogStatement Logger calls should be surrounded by log level guards. 2 135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 137
LongVariable Avoid excessively long variable names like bagInfoEntryRequirement 3 142
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 144
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 144
GuardLogStatement Logger calls should be surrounded by log level guards. 2 145
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 145
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 145
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 149
LongVariable Avoid excessively long variable names like bagInfoEntryRequirement 3 155
LongVariable Avoid excessively long variable names like metadataContainsKey 3 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 157
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 158
LongVariable Avoid excessively long variable names like requiredManifestTypes 3 164
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'manifestTypesPresent' (lines '165'-'185'). 5 165–185
LongVariable Avoid excessively long variable names like manifestTypesPresent 3 165
GuardLogStatement Logger calls should be surrounded by log level guards. 2 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 169
LongVariable Avoid excessively long variable names like requiredManifestType 3 172
ShortVariable Avoid variables with short names like sb 3 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 176
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 179
LongVariable Avoid excessively long variable names like requiredTagFilePaths 3 187
GuardLogStatement Logger calls should be surrounded by log level guards. 2 189
LongVariable Avoid excessively long variable names like requiredTagFilePath 3 191

nl/knaw/dans/bagit/conformance/BagitWarning.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 22
CommentSize Comment is too large: Line too long 3 23
CommentRequired Field comments are required 3 41
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 42
CommentRequired Field comments are required 3 42
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 42
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'BagitWarning(String)': enum constructors are implicitly private 3 44–46
CommentRequired Public method and constructor comments are required 3 48–50

nl/knaw/dans/bagit/conformance/EncodingChecker.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 29
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 32
FieldNamingConventions The public constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 32
CommentRequired Field comments are required 3 32
FieldNamingConventions The public constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 33
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 33
CommentRequired Field comments are required 3 33
CommentRequired Public method and constructor comments are required 3 38–43
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 39
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 40
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 40

nl/knaw/dans/bagit/conformance/ManifestChecker.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 52
CommentRequired Field comments are required 3 52
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 52
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 53
CommentRequired Field comments are required 3 53
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 53
CommentRequired Field comments are required 3 55
CommentRequired Field comments are required 3 56
CommentRequired Field comments are required 3 57
CommentRequired Field comments are required 3 58
CommentRequired Field comments are required 3 59
CommentRequired Field comments are required 3 60
CommentRequired Field comments are required 3 61
CommentSize Comment is too large: Too many lines 3 67–80
CommentSize Comment is too large: Line too long 3 76
CommentSize Comment is too large: Line too long 3 77
CommentSize Comment is too large: Line too long 3 78
CommentSize Comment is too large: Line too long 3 79
LongVariable Avoid excessively long variable names like missingTagManifest 3 84
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'payloadManifests' (lines '85'-'101'). 5 85–101
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'tagManifests' (lines '86'-'101'). 5 86–101
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'files': resource specifications are implicitly final 3 87
GuardLogStatement Logger calls should be surrounded by log level guards. 2 98
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 98
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 98
LongVariable Avoid excessively long variable names like missingTagManifest 3 106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'missingTagManifest' (lines '106'-'116'). 5 106–116
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 108
CommentSize Comment is too large: Line too long 3 127
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 3 133
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paths' (lines '134'-'155'). 5 134–155
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 143
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 145
DefaultPackage Use explicit scoping instead of the default package private level 3 160–168
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the parsePath method if you want a default access modifier 3 160–168
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 162
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 164
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fixedPath' (lines '174'-'178'). 5 174–178
GuardLogStatement Logger calls should be surrounded by log level guards. 2 182
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 182
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 182
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 195
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 195
GuardLogStatement Logger calls should be surrounded by log level guards. 2 195
CommentSize Comment is too large: Line too long 3 201
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 206
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 207
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 210
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'normalizedFileToCheck' (lines '212'-'225'). 5 212–225
LongVariable Avoid excessively long variable names like normalizedFileToCheck 3 212
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'files': resource specifications are implicitly final 3 214
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 218
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 219
GuardLogStatement Logger calls should be surrounded by log level guards. 2 219
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 219
DefaultPackage Use explicit scoping instead of the default package private level 3 230–232
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the normalizePathToNFD method if you want a default access modifier 3 230–232
GuardLogStatement Logger calls should be surrounded by log level guards. 2 239
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 249
GuardLogStatement Logger calls should be surrounded by log level guards. 2 249
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 249
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 259
GuardLogStatement Logger calls should be surrounded by log level guards. 2 259
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 259
DefaultPackage Use explicit scoping instead of the default package private level 3 267–279
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the checkAlgorthm method if you want a default access modifier 3 267–279
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 270
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 270
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 271
GuardLogStatement Logger calls should be surrounded by log level guards. 2 271
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 271
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 276
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 276
GuardLogStatement Logger calls should be surrounded by log level guards. 2 276
DefaultPackage Use explicit scoping instead of the default package private level 3 281–293
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the checkManifestSets method if you want a default access modifier 3 281–293
CommentSize Comment is too large: Line too long 3 289
CommentSize Comment is too large: Line too long 3 295
DefaultPackage Use explicit scoping instead of the default package private level 3 296–320
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the checkManifestsListSameSetOfFiles method if you want a default access modifier 3 297–320
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'nameMapping' (lines '298'-'320'). 5 298–320
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'compareToManifest' (lines '300'-'320'). 5 300–320
LongVariable Avoid excessively long variable names like compareToManifestPath 3 301
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'compareToManifestPath' (lines '301'-'320'). 5 301–320
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'compareToManifestPath' (lines '301'-'306'). 5 301–306
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'compareToManifestPath' (lines '306'-'306'). 5 306
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'compareToManifestPath' (lines '306'-'320'). 5 306–320
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 311
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 312
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 312
GuardLogStatement Logger calls should be surrounded by log level guards. 2 312
DefaultPackage Use explicit scoping instead of the default package private level 3 323–325
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getOsFilesRegex method if you want a default access modifier 3 323–325

nl/knaw/dans/bagit/conformance/MetadataChecker.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 37
CommentRequired Field comments are required 3 37
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 37
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 38
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 38
CommentRequired Field comments are required 3 38
CommentRequired Public method and constructor comments are required 3 44–47
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'containsPayloadOxum' (lines '56'-'60'). 5 56–60
LongVariable Avoid excessively long variable names like containsPayloadOxum 3 56
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'containsPayloadOxum' (lines '60'-'60'). 5 60
GuardLogStatement Logger calls should be surrounded by log level guards. 2 65

nl/knaw/dans/bagit/conformance/VersionChecker.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The public constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 32
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 32
CommentRequired Field comments are required 3 32
CommentRequired Field comments are required 3 33
LongVariable Avoid excessively long variable names like LATEST_BAGIT_VERSION 3 33
CommentRequired Field comments are required 3 34
FieldNamingConventions The public constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 34
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 34
CommentRequired Public method and constructor comments are required 3 39–44
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 41
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 41

nl/knaw/dans/bagit/conformance/profile/BagInfoRequirement.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 23
DataClass The class 'BagInfoRequirement' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=6, WMC=13) 3 25–94
CommentRequired Field comments are required 3 26
CommentRequired Field comments are required 3 27
CommentRequired Field comments are required 3 28
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 33
CommentRequired Public method and constructor comments are required 3 46–48
CommentSize Comment is too large: Line too long 3 50

nl/knaw/dans/bagit/conformance/profile/BagitProfile.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 26
AtLeastOneConstructor Each class should declare at least one constructor 3 28–174
DataClass The class 'BagitProfile' is suspected to be a Data Class (WOC=9.091%, NOPA=0, NOAM=30, WMC=34) 3 28–174
LongVariable Avoid excessively long variable names like bagitProfileIdentifier 3 29
CommentRequired Field comments are required 3 29
LongVariable Avoid excessively long variable names like sourceOrganization 3 30
CommentRequired Field comments are required 3 30
LongVariable Avoid excessively long variable names like externalDescription 3 31
CommentRequired Field comments are required 3 31
CommentRequired Field comments are required 3 32
CommentRequired Field comments are required 3 33
CommentRequired Field comments are required 3 34
CommentRequired Field comments are required 3 35
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 37
LongVariable Avoid excessively long variable names like bagInfoRequirements 3 37
CommentRequired Field comments are required 3 37
CommentRequired Field comments are required 3 38
LongVariable Avoid excessively long variable names like manifestTypesRequired 3 38
CommentRequired Field comments are required 3 39
CommentRequired Field comments are required 3 40
LongVariable Avoid excessively long variable names like acceptableMIMESerializationTypes 3 41
CommentRequired Field comments are required 3 41
CommentRequired Field comments are required 3 42
LongVariable Avoid excessively long variable names like acceptableBagitVersions 3 42
LongVariable Avoid excessively long variable names like tagManifestTypesRequired 3 43
CommentRequired Field comments are required 3 43
CommentRequired Field comments are required 3 44
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 50
LongVariable Avoid excessively long variable names like acceptSerialization 3 111
LongVariable Avoid excessively long variable names like acceptBagitVersion 3 117
LongVariable Avoid excessively long variable names like tagManifestsRequired 3 123
LongVariable Avoid excessively long variable names like bagitProfileIdentifier 3 135
LongVariable Avoid excessively long variable names like sourceOrganization 3 141
LongVariable Avoid excessively long variable names like externalDescription 3 147

nl/knaw/dans/bagit/conformance/profile/BagitProfileDeserializer.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 42
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 42
CommentRequired Field comments are required 3 42
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 43
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 43
CommentRequired Field comments are required 3 43
CommentRequired Public method and constructor comments are required 3 45–47
ShortVariable Avoid variables with short names like vc 3 49
CommentRequired Public method and constructor comments are required 3 49–51
ShortVariable Avoid variables with short names like p 3 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 57
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 65
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 66
GuardLogStatement Logger calls should be surrounded by log level guards. 2 66
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 66
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 68
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 68
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 69
GuardLogStatement Logger calls should be surrounded by log level guards. 2 69
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 71
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
GuardLogStatement Logger calls should be surrounded by log level guards. 2 83
LongVariable Avoid excessively long variable names like bagitProfileInfoNode 3 85
CommentSize Comment is too large: Line too long 3 91
LongVariable Avoid excessively long variable names like bagitProfileInfoNode 3 97
GuardLogStatement Logger calls should be surrounded by log level guards. 2 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100
GuardLogStatement Logger calls should be surrounded by log level guards. 2 101
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 101
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 104
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 105
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 105
GuardLogStatement Logger calls should be surrounded by log level guards. 2 105
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 108
GuardLogStatement Logger calls should be surrounded by log level guards. 2 109
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 109
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 113
GuardLogStatement Logger calls should be surrounded by log level guards. 2 113
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 113
CommentSize Comment is too large: Line too long 3 118
LongVariable Avoid excessively long variable names like bagitProfileInfoNode 3 123
GuardLogStatement Logger calls should be surrounded by log level guards. 2 124
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 129
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 129
GuardLogStatement Logger calls should be surrounded by log level guards. 2 129
GuardLogStatement Logger calls should be surrounded by log level guards. 2 136
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 136
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 136
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 143
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 143
GuardLogStatement Logger calls should be surrounded by log level guards. 2 143
GuardLogStatement Logger calls should be surrounded by log level guards. 2 151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 152
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 161
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 161
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 163
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 169
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 173
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 173
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 175
GuardLogStatement Logger calls should be surrounded by log level guards. 2 178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 179
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 194
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 194
GuardLogStatement Logger calls should be surrounded by log level guards. 2 194
LongVariable Avoid excessively long variable names like serialiationFormats 3 200
LongVariable Avoid excessively long variable names like serialiationFormat 3 203
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 206
GuardLogStatement Logger calls should be surrounded by log level guards. 2 206
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 206
LongVariable Avoid excessively long variable names like tagManifestsRequiredNodes 3 212
LongVariable Avoid excessively long variable names like requiredTagmanifestTypes 3 213
LongVariable Avoid excessively long variable names like tagManifestsRequiredNode 3 215
GuardLogStatement Logger calls should be surrounded by log level guards. 2 219
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 219
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 219
LongVariable Avoid excessively long variable names like tagFilesRequiredNodes 3 225
LongVariable Avoid excessively long variable names like tagFilesRequiredNode 3 229
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 233
GuardLogStatement Logger calls should be surrounded by log level guards. 2 233
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 233
LongVariable Avoid excessively long variable names like acceptableVersionsNodes 3 239
LongVariable Avoid excessively long variable names like acceptableVersions 3 240
LongVariable Avoid excessively long variable names like acceptableVersionsNode 3 242
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 245
GuardLogStatement Logger calls should be surrounded by log level guards. 2 245
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 245

nl/knaw/dans/bagit/conformance/profile/Serialization.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The enum constant name 'forbidden' doesn't match '[A-Z][A-Z_0-9]*' 1 22
FieldNamingConventions The enum constant name 'required' doesn't match '[A-Z][A-Z_0-9]*' 1 23
FieldNamingConventions The enum constant name 'optional' doesn't match '[A-Z][A-Z_0-9]*' 1 24

nl/knaw/dans/bagit/creator/AbstractCreateManifestsVistor.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 35
CommentRequired Field comments are required 3 39
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 39
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 39
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 40
CommentRequired Field comments are required 3 40
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 40
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 3 42
CommentRequired Field comments are required 3 42
LongVariable Avoid excessively long variable names like includeHiddenFiles 3 43
CommentRequired Field comments are required 3 43
CommentRequired Public method and constructor comments are required 3 45–48
LongVariable Avoid excessively long variable names like includeHiddenFiles 3 45
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 3 45
CallSuperInConstructor It is a good practice to call super() in a constructor 3 45–48
CommentRequired Public method and constructor comments are required 3 50–61
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 52
GuardLogStatement Logger calls should be surrounded by log level guards. 2 52
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 52
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 53
GuardLogStatement Logger calls should be surrounded by log level guards. 2 56
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 56
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 56
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 57
GuardLogStatement Logger calls should be surrounded by log level guards. 2 66
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 66
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 66

nl/knaw/dans/bagit/creator/BagCreator.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 51
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 51
CommentRequired Field comments are required 3 51
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 52
CommentRequired Field comments are required 3 52
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 52
CommentRequired Field comments are required 3 53
CommentRequired Field comments are required 3 54
LongVariable Avoid excessively long variable names like LATEST_NON_DOT_BAGIT_VERSION 3 55
CommentRequired Field comments are required 3 55
CommentSize Comment is too large: Too many lines 3 59–72
CommentSize Comment is too large: Line too long 3 61
CommentSize Comment is too large: Line too long 3 64
CommentSize Comment is too large: Line too long 3 66
CommentSize Comment is too large: Line too long 3 68
CommentSize Comment is too large: Too many lines 3 77–91
CommentSize Comment is too large: Line too long 3 79
CommentSize Comment is too large: Line too long 3 82
CommentSize Comment is too large: Line too long 3 84
CommentSize Comment is too large: Line too long 3 85
CommentSize Comment is too large: Line too long 3 87
CommentSize Comment is too large: Too many lines 3 96–109
CommentSize Comment is too large: Line too long 3 98
CommentSize Comment is too large: Line too long 3 101
CommentSize Comment is too large: Line too long 3 103
CommentSize Comment is too large: Line too long 3 105
CommentSize Comment is too large: Too many lines 3 115–129
CommentSize Comment is too large: Line too long 3 117
CommentSize Comment is too large: Line too long 3 120
CommentSize Comment is too large: Line too long 3 122
CommentSize Comment is too large: Line too long 3 123
CommentSize Comment is too large: Line too long 3 125
GuardLogStatement Logger calls should be surrounded by log level guards. 2 137
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 137
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 161
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'directoryStream': resource specifications are implicitly final 3 171
GuardLogStatement Logger calls should be surrounded by log level guards. 2 182
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 192
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 192
GuardLogStatement Logger calls should be surrounded by log level guards. 2 199
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 199
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 199
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 201
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 203
GuardLogStatement Logger calls should be surrounded by log level guards. 2 206
GuardLogStatement Logger calls should be surrounded by log level guards. 2 211
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 222
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 222

nl/knaw/dans/bagit/creator/CreatePayloadManifestsVistor.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 28
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 3 33
LongVariable Avoid excessively long variable names like includeHiddenFiles 3 33
CommentRequired Public method and constructor comments are required 3 33–35

nl/knaw/dans/bagit/creator/CreateTagManifestsVistor.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 28
LongVariable Avoid excessively long variable names like includeHiddenFiles 3 33
CommentRequired Public method and constructor comments are required 3 33–35
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 3 33

nl/knaw/dans/bagit/domain/Bag.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
DataClass The class 'Bag' is suspected to be a Data Class (WOC=15.000%, NOPA=0, NOAM=14, WMC=25) 3 30–184
ShortClassName Avoid short class names like Bag 4 30–184
CommentRequired Field comments are required 3 32
CommentRequired Field comments are required 3 35
CommentRequired Field comments are required 3 38
CommentRequired Field comments are required 3 41
CommentRequired Field comments are required 3 44
CommentRequired Field comments are required 3 47
CommentRequired Field comments are required 3 50
ShortVariable Avoid variables with short names like sb 3 129
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 155
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 158
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 161
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 165
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 166
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 167
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 168
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 169
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 170

nl/knaw/dans/bagit/domain/FetchItem.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 24
CommentRequired Field comments are required 3 42
ShortVariable Avoid variables with short names like sb 3 57
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 101
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 104
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 107
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 112

nl/knaw/dans/bagit/domain/Manifest.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 26
CommentRequired Field comments are required 3 29
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 30
CommentRequired Field comments are required 3 30
CommentRequired Public method and constructor comments are required 3 32–34
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 61
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 64
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 67
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 72

nl/knaw/dans/bagit/domain/Metadata.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
AtLeastOneConstructor Each class should declare at least one constructor 3 30–179
CommentRequired Field comments are required 3 31
CommentRequired Field comments are required 3 32
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 32
CommentRequired Field comments are required 3 33
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 47
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 48
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 49
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 92
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 121
CommentSize Comment is too large: Line too long 3 136
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'entryToRemove' (lines '143'-'146'). 5 143–146
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'entryToRemove' (lines '146'-'146'). 5 146

nl/knaw/dans/bagit/domain/Version.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Field comments are required 3 24
CommentRequired Field comments are required 3 25
CommentRequired Field comments are required 3 27
CommentRequired Public method and constructor comments are required 3 29–33
MethodNamingConventions The static method name 'LATEST_BAGIT_VERSION' doesn't match '[a-z][a-zA-Z0-9]*' 1 35–37
CommentRequired Public method and constructor comments are required 3 35–37
ShortVariable Avoid variables with short names like o 3 45
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 50
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 53
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 67
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 70
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 73
CommentRequired Public method and constructor comments are required 3 81–83
CommentRequired Public method and constructor comments are required 3 85–87
CommentRequired Public method and constructor comments are required 3 89–91
CommentRequired Public method and constructor comments are required 3 93–95

nl/knaw/dans/bagit/exceptions/CorruptChecksumException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 23
CommentRequired Public method and constructor comments are required 3 28–30

nl/knaw/dans/bagit/exceptions/FileNotInManifestException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 21
CommentRequired Public method and constructor comments are required 3 27–29

nl/knaw/dans/bagit/exceptions/FileNotInPayloadDirectoryException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 19
CommentRequired Public method and constructor comments are required 3 25–27

nl/knaw/dans/bagit/exceptions/InvalidBagMetadataException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 19
CommentRequired Public method and constructor comments are required 3 29–31

nl/knaw/dans/bagit/exceptions/InvalidBagitFileFormatException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 19
CommentRequired Public method and constructor comments are required 3 24–26
ShortVariable Avoid variables with short names like e 3 28
CommentRequired Public method and constructor comments are required 3 28–30

nl/knaw/dans/bagit/exceptions/InvalidPayloadOxumException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 19
CommentRequired Public method and constructor comments are required 3 25–27

nl/knaw/dans/bagit/exceptions/MaliciousPathException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 19
CommentSize Comment is too large: Line too long 3 20
CommentRequired Public method and constructor comments are required 3 25–27

nl/knaw/dans/bagit/exceptions/MissingBagitFileException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 19
CommentRequired Public method and constructor comments are required 3 24–26

nl/knaw/dans/bagit/exceptions/MissingPayloadDirectoryException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 23
CommentRequired Public method and constructor comments are required 3 28–30

nl/knaw/dans/bagit/exceptions/MissingPayloadManifestException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 19
CommentRequired Public method and constructor comments are required 3 24–26

nl/knaw/dans/bagit/exceptions/PayloadOxumDoesNotExistException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 21
CommentSize Comment is too large: Line too long 3 22
CommentRequired Public method and constructor comments are required 3 27–29

nl/knaw/dans/bagit/exceptions/UnparsableVersionException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 21
CommentRequired Public method and constructor comments are required 3 26–28

nl/knaw/dans/bagit/exceptions/UnsupportedAlgorithmException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 23
LongVariable Avoid excessively long variable names like bagitAlgorithmName 3 28
CommentRequired Public method and constructor comments are required 3 28–30

nl/knaw/dans/bagit/exceptions/VerificationException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Public method and constructor comments are required 3 24–26

nl/knaw/dans/bagit/exceptions/conformance/BagitVersionIsNotAcceptableException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 24
CommentRequired Public method and constructor comments are required 3 29–31
LongVariable Avoid excessively long variable names like acceptableVersions 3 29

nl/knaw/dans/bagit/exceptions/conformance/FetchFileNotAllowedException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 23
CommentRequired Public method and constructor comments are required 3 28–30

nl/knaw/dans/bagit/exceptions/conformance/MetatdataValueIsNotAcceptableException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 23
CommentRequired Public method and constructor comments are required 3 28–30

nl/knaw/dans/bagit/exceptions/conformance/MetatdataValueIsNotRepeatableException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Public method and constructor comments are required 3 26–28

nl/knaw/dans/bagit/exceptions/conformance/RequiredManifestNotPresentException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 19
CommentRequired Public method and constructor comments are required 3 24–26

nl/knaw/dans/bagit/exceptions/conformance/RequiredMetadataFieldNotPresentException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Public method and constructor comments are required 3 26–28
LongVariable Avoid excessively long variable names like bagInfoEntryRequirementKey 3 26

nl/knaw/dans/bagit/exceptions/conformance/RequiredTagFileNotPresentException.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Public method and constructor comments are required 3 26–28
LongVariable Avoid excessively long variable names like requiredTagFilePath 3 26

nl/knaw/dans/bagit/hash/BagitAlgorithmNameToSupportedAlgorithmMapping.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 21
LongVariable Avoid excessively long variable names like bagitAlgorithmName 3 24
CommentRequired Public method and constructor comments are required 3 24

nl/knaw/dans/bagit/hash/Hasher.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Field comments are required 3 42
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 42
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 42
FieldNamingConventions The constant name '_64_KB' doesn't match '[A-Z][A-Z_0-9]*' 1 43
CommentRequired Field comments are required 3 43
CommentRequired Field comments are required 3 44
CommentRequired Field comments are required 3 45
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 45
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 45
CommentSize Comment is too large: Line too long 3 55
CommentSize Comment is too large: Line too long 3 69
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 3 72
DefaultPackage Use explicit scoping instead of the default package private level 3 77–89
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the updateMessageDigests method if you want a default access modifier 3 77–89
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'is': resource specifications are implicitly final 3 78
ShortVariable Avoid variables with short names like is 3 78
LongVariable Avoid excessively long variable names like manifestToMessageDigestMap 3 91
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 94
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 94
GuardLogStatement Logger calls should be surrounded by log level guards. 2 94
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 95
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'formatter': resource specifications are implicitly final 3 101
CommentSize Comment is too large: Line too long 3 111
CommentSize Comment is too large: Line too long 3 113
CommentSize Comment is too large: Line too long 3 115
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 119

nl/knaw/dans/bagit/hash/StandardBagitAlgorithmNameToSupportedAlgorithmMapping.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
AtLeastOneConstructor Each class should declare at least one constructor 3 26–39
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 28
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 28
CommentRequired Field comments are required 3 28
LongVariable Avoid excessively long variable names like bagitAlgorithmName 3 31

nl/knaw/dans/bagit/hash/StandardSupportedAlgorithms.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Field comments are required 3 28
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'StandardSupportedAlgorithms(String)': enum constructors are implicitly private 3 30–32
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 42

nl/knaw/dans/bagit/hash/SupportedAlgorithm.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Public method and constructor comments are required 3 25
CommentRequired Public method and constructor comments are required 3 26

nl/knaw/dans/bagit/reader/BagReader.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Field comments are required 3 38
CommentRequired Public method and constructor comments are required 3 40–42
CommentRequired Public method and constructor comments are required 3 44–46
CommentSize Comment is too large: Too many lines 3 48–60
CommentSize Comment is too large: Line too long 3 55
CommentSize Comment is too large: Line too long 3 56
CommentSize Comment is too large: Line too long 3 57
CommentSize Comment is too large: Line too long 3 58
CommentSize Comment is too large: Line too long 3 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 71
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 73
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 78
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 82

nl/knaw/dans/bagit/reader/BagitTextFileReader.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 38
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 41
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 41
CommentRequired Field comments are required 3 41
UseShortArrayInitializer Array initialization can be written shorter 3 42
CommentRequired Field comments are required 3 42
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 43
CommentRequired Field comments are required 3 43
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 43
CommentRequired Field comments are required 3 44
CommentRequired Field comments are required 3 45
CommentRequired Field comments are required 3 46
CommentSize Comment is too large: Too many lines 3 52–62
CommentSize Comment is too large: Line too long 3 58
CommentSize Comment is too large: Line too long 3 59
CommentSize Comment is too large: Line too long 3 60
CommentSize Comment is too large: Line too long 3 61
GuardLogStatement Logger calls should be surrounded by log level guards. 2 64
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 64
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 64
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'version' (lines '68'-'72'). 5 68–72
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'encoding' (lines '69'-'76'). 5 69–76
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 73
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 73
GuardLogStatement Logger calls should be surrounded by log level guards. 2 73
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 77
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 77
GuardLogStatement Logger calls should be surrounded by log level guards. 2 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 86
LongVariable Avoid excessively long variable names like firstFewBytesInFile 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
CommentSize Comment is too large: Line too long 3 106
DefaultPackage Use explicit scoping instead of the default package private level 3 110–124
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the throwErrorIfLinesDoNotMatchStrict method if you want a default access modifier 3 110–124
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 111
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113–114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 117–118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 120
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 121–122
CommentRequired Public method and constructor comments are required 3 129–143
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 134

nl/knaw/dans/bagit/reader/FetchReader.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 36
CommentRequired Field comments are required 3 39
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 39
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 39
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 40
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 40
CommentRequired Field comments are required 3 40
CommentRequired Field comments are required 3 41
CommentSize Comment is too large: Too many lines 3 47–58
CommentSize Comment is too large: Line too long 3 56
CommentSize Comment is too large: Line too long 3 57
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 61
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 61
GuardLogStatement Logger calls should be surrounded by log level guards. 2 61
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'itemsToFetch' (lines '62'-'89'). 5 62–89
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 3 64
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'parts' (lines '66'-'71'). 5 66–71
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'parts' (lines '66'-'89'). 5 66–89
UnusedAssignment The initializer for variable 'parts' is never used (overwritten on line 71) 3 66
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'length' (lines '67'-'89'). 5 67–89
UnusedAssignment The initializer for variable 'length' is never used (overwritten on line 73) 3 67
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'length' (lines '67'-'73'). 5 67–73
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'url' (lines '68'-'89'). 5 68–89
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'url' (lines '68'-'74'). 5 68–74
UnusedAssignment The initializer for variable 'url' is never used (overwritten on line 74) 3 68
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 70
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 70
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 71
LiteralsFirstInComparisons Position literals first in String comparisons 3 73
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 4 5 76
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 4 5 76
GuardLogStatement Logger calls should be surrounded by log level guards. 2 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81

nl/knaw/dans/bagit/reader/KeyValueReader.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 38
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 38
CommentRequired Field comments are required 3 38
LongVariable Avoid excessively long variable names like INDENTED_LINE_REGEX 3 39
CommentRequired Field comments are required 3 39
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 40
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 40
CommentRequired Field comments are required 3 40
CommentSize Comment is too large: Too many lines 3 47–58
CommentSize Comment is too large: Line too long 3 48
CommentSize Comment is too large: Line too long 3 57
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 3 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 66
GuardLogStatement Logger calls should be surrounded by log level guards. 2 73
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 4 5 73
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 4 5 73
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 86
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 86
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
GuardLogStatement Logger calls should be surrounded by log level guards. 2 89
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 89
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 89
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 97

nl/knaw/dans/bagit/reader/ManifestReader.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 42
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 45
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 45
CommentRequired Field comments are required 3 45
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 46
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 46
CommentRequired Field comments are required 3 46
CommentSize Comment is too large: Too many lines 3 52–64
CommentSize Comment is too large: Line too long 3 53
CommentSize Comment is too large: Line too long 3 55
CommentSize Comment is too large: Line too long 3 61
CommentSize Comment is too large: Line too long 3 62
CommentSize Comment is too large: Line too long 3 63
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the readAllManifests method if you want a default access modifier 3 65–82
DefaultPackage Use explicit scoping instead of the default package private level 3 65–82
GuardLogStatement Logger calls should be surrounded by log level guards. 2 66
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'manifests': resource specifications are implicitly final 3 68
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 72
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 73
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 73
GuardLogStatement Logger calls should be surrounded by log level guards. 2 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 77
GuardLogStatement Logger calls should be surrounded by log level guards. 2 77
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 78
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'filter' (lines '88'-'98'). 5 88–98
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'filter' (lines '88'-'98'). 5 88–98
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 91
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 93
CommentSize Comment is too large: Too many lines 3 100–113
CommentSize Comment is too large: Line too long 3 103
CommentSize Comment is too large: Line too long 3 110
CommentSize Comment is too large: Line too long 3 111
CommentSize Comment is too large: Line too long 3 112
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 117
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 117
GuardLogStatement Logger calls should be surrounded by log level guards. 2 117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 118
LongVariable Avoid excessively long variable names like filetToChecksumMap 3 123
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the readChecksumFileMap method if you want a default access modifier 3 132–146
DefaultPackage Use explicit scoping instead of the default package private level 3 132–146
ShortVariable Avoid variables with short names like br 3 134
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'br': resource specifications are implicitly final 3 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 137

nl/knaw/dans/bagit/reader/MetadataReader.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 33
CommentRequired Field comments are required 3 36
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 36
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 36
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 37
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 37
CommentRequired Field comments are required 3 37
CommentSize Comment is too large: Too many lines 3 43–52
CommentSize Comment is too large: Line too long 3 51
GuardLogStatement Logger calls should be surrounded by log level guards. 2 54
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'metadata' (lines '55'-'60'). 5 55–60
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'metadata' (lines '55'-'65'). 5 55–65
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 59
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 59
GuardLogStatement Logger calls should be surrounded by log level guards. 2 59
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'metadata' (lines '60'-'65'). 5 60–65
GuardLogStatement Logger calls should be surrounded by log level guards. 2 64
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 64
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 64

nl/knaw/dans/bagit/reader/TagFileReader.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 36
CommentRequired Field comments are required 3 36
FieldNamingConventions The public constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 36
CommentRequired Field comments are required 3 37
FieldNamingConventions The public constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 37
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 37
CommentRequired Field comments are required 3 38
CommentSize Comment is too large: Line too long 3 41
CommentRequired Public method and constructor comments are required 3 43–80
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'fixedPath' (lines '44'-'80'). 5 44–80
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fixedPath' (lines '44'-'47'). 5 44–47
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 45
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'fixedPath' (lines '47'-'80'). 5 47–80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 57
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 62
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'file' (lines '64'-'80'). 5 64–80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 67
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 71
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 76

nl/knaw/dans/bagit/util/PathUtils.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentRequired Field comments are required 3 31
LongVariable Avoid excessively long variable names like DOT_BAGIT_DIR_NAME 3 34
CommentRequired Field comments are required 3 34
CommentSize Comment is too large: Line too long 3 41
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'filename' (lines '47'-'51'). 5 47–51
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 51
CommentSize Comment is too large: Line too long 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 64
CommentSize Comment is too large: Line too long 3 68
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 73
CommentSize Comment is too large: Line too long 3 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 86
CommentSize Comment is too large: Line too long 3 94
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105
CommentSize Comment is too large: Too many lines 3 108–117
CommentSize Comment is too large: Line too long 3 110
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 120
CommentSize Comment is too large: Line too long 3 127
CommentSize Comment is too large: Line too long 3 128
CommentSize Comment is too large: Line too long 3 132
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 136
CommentSize Comment is too large: Too many lines 3 142–150
CommentSize Comment is too large: Line too long 3 143
CommentSize Comment is too large: Line too long 3 144
CommentSize Comment is too large: Line too long 3 149
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 153
CommentSize Comment is too large: Too many lines 3 159–167

nl/knaw/dans/bagit/verify/AbstractPayloadFileExistsInManifestsVistor.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 32
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 35
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 35
CommentRequired Field comments are required 3 35
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 36
CommentRequired Field comments are required 3 36
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 36
CommentRequired Field comments are required 3 37
CallSuperInConstructor It is a good practice to call super() in a constructor 3 39–41
CommentRequired Public method and constructor comments are required 3 39–41
GuardLogStatement Logger calls should be surrounded by log level guards. 2 46
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 46
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 46
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 47

nl/knaw/dans/bagit/verify/BagVerifier.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 52
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 52
CommentRequired Field comments are required 3 52
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 53
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 53
CommentRequired Field comments are required 3 53
CommentRequired Field comments are required 3 55
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 56
CommentRequired Field comments are required 3 56
CommentSize Comment is too large: Line too long 3 69
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 81
CommentSize Comment is too large: Line too long 3 88
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 91
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 97
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 99
CommentSize Comment is too large: Line too long 3 104
CommentSize Comment is too large: Too many lines 3 113–123
CommentSize Comment is too large: Line too long 3 114
CommentSize Comment is too large: Line too long 3 119
CommentSize Comment is too large: Line too long 3 120
CommentSize Comment is too large: Line too long 3 121
CommentSize Comment is too large: Too many lines 3 128–148
CommentSize Comment is too large: Line too long 3 129
CommentSize Comment is too large: Line too long 3 134
CommentSize Comment is too large: Line too long 3 136
CommentSize Comment is too large: Line too long 3 138
CommentSize Comment is too large: Line too long 3 139
CommentSize Comment is too large: Line too long 3 142
CommentSize Comment is too large: Line too long 3 143
CommentSize Comment is too large: Line too long 3 144
CommentSize Comment is too large: Line too long 3 145
CommentSize Comment is too large: Line too long 3 146
CommentSize Comment is too large: Line too long 3 147
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 150
GuardLogStatement Logger calls should be surrounded by log level guards. 2 150
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 150
GuardLogStatement Logger calls should be surrounded by log level guards. 2 153
GuardLogStatement Logger calls should be surrounded by log level guards. 2 158
DefaultPackage Use explicit scoping instead of the default package private level 3 167–189
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the checkHashes method if you want a default access modifier 3 168–189
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 169
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 174
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 175
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 175
ShortVariable Avoid variables with short names like e 3 181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 181
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 183
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 183
CommentSize Comment is too large: Too many lines 3 191–214
CommentSize Comment is too large: Line too long 3 192
CommentSize Comment is too large: Line too long 3 197
CommentSize Comment is too large: Line too long 3 198
CommentSize Comment is too large: Line too long 3 203
CommentSize Comment is too large: Line too long 3 206
CommentSize Comment is too large: Line too long 3 209
CommentSize Comment is too large: Line too long 3 210
CommentSize Comment is too large: Line too long 3 211
CommentSize Comment is too large: Line too long 3 212
CommentSize Comment is too large: Line too long 3 213
GuardLogStatement Logger calls should be surrounded by log level guards. 2 218
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 218
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 218
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 231

nl/knaw/dans/bagit/verify/CheckIfFileExistsTask.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 31
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 33
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 35
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 35
CommentRequired Field comments are required 3 35
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 36
CommentRequired Field comments are required 3 36
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 36
CommentRequired Field comments are required 3 37
CommentRequired Field comments are required 3 38
CommentRequired Field comments are required 3 39
CommentRequired Public method and constructor comments are required 3 41–45
GuardLogStatement Logger calls should be surrounded by log level guards. 2 53
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 53
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 53
CommentSize Comment is too large: Line too long 3 64
CommentSize Comment is too large: Line too long 3 65
CommentSize Comment is too large: Line too long 3 67
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'normalizedFile' (lines '70'-'87'). 5 70–87
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'files': resource specifications are implicitly final 3 73
LongVariable Avoid excessively long variable names like normalizedFileToCheck 3 75
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 77
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 82
GuardLogStatement Logger calls should be surrounded by log level guards. 2 82
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 82

nl/knaw/dans/bagit/verify/CheckManifestHashesTask.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 35
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 40
CommentRequired Field comments are required 3 40
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 40
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 41
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 41
CommentRequired Field comments are required 3 41
CommentRequired Field comments are required 3 43
CommentRequired Field comments are required 3 44
CommentRequired Field comments are required 3 45
CommentRequired Field comments are required 3 46
CommentRequired Public method and constructor comments are required 3 48–53
CommentRequired Protected method constructor comments are required 3 66–76
GuardLogStatement Logger calls should be surrounded by log level guards. 2 68
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 68
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 68
GuardLogStatement Logger calls should be surrounded by log level guards. 2 70
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 71
CommentSize Comment is too large: Line too long 3 75

nl/knaw/dans/bagit/verify/FileCountAndTotalSizeVistor.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 31
AtLeastOneConstructor Each class should declare at least one constructor 3 33–67
CommentRequired Field comments are required 3 34
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 34
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 34
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 35
CommentRequired Field comments are required 3 35
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 35
CommentRequired Field comments are required 3 37
CommentRequired Field comments are required 3 38
GuardLogStatement Logger calls should be surrounded by log level guards. 2 43
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 43
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 43
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 44
GuardLogStatement Logger calls should be surrounded by log level guards. 2 54
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 54
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 54

nl/knaw/dans/bagit/verify/MandatoryVerifier.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 40
CommentRequired Field comments are required 3 43
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 43
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 43
CommentRequired Field comments are required 3 44
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 44
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 44
LongVariable Avoid excessively long variable names like DOT_BAGIT_DIR_NAME 3 47
CommentRequired Field comments are required 3 47
CommentSize Comment is too large: Line too long 3 58
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 61
GuardLogStatement Logger calls should be surrounded by log level guards. 2 61
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 65
CommentSize Comment is too large: Line too long 3 75
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'bagitFile' (lines '79'-'82'). 5 79–82
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 87
CommentSize Comment is too large: Line too long 3 95
GuardLogStatement Logger calls should be surrounded by log level guards. 2 98
CommentSize Comment is too large: Too many lines 3 109–117
CommentSize Comment is too large: Line too long 3 115
LongVariable Avoid excessively long variable names like hasAtLeastOneManifest 3 120
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'hasAtLeastOneManifest' (lines '120'-'126'). 5 120–126
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 124
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 125
GuardLogStatement Logger calls should be surrounded by log level guards. 2 125
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 125
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'hasAtLeastOneManifest' (lines '126'-'126'). 5 126

nl/knaw/dans/bagit/verify/ManifestVerifier.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 50
CommentRequired Field comments are required 3 50
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 50
CommentRequired Field comments are required 3 51
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 51
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 51
CommentRequired Field comments are required 3 53
CommentRequired Field comments are required 3 54
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 54
CommentSize Comment is too large: Line too long 3 67
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 79
CommentSize Comment is too large: Line too long 3 86
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 89
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 95
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 97
CommentSize Comment is too large: Too many lines 3 100–113
CommentSize Comment is too large: Line too long 3 101
CommentSize Comment is too large: Line too long 3 105
CommentSize Comment is too large: Line too long 3 108
CommentSize Comment is too large: Line too long 3 109
CommentSize Comment is too large: Line too long 3 110
CommentSize Comment is too large: Line too long 3 111
LongVariable Avoid excessively long variable names like allFilesListedInManifests 3 118
GuardLogStatement Logger calls should be surrounded by log level guards. 2 133
LongVariable Avoid excessively long variable names like filesListedInManifests 3 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 140
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 140
GuardLogStatement Logger calls should be surrounded by log level guards. 2 141
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 141
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 144
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 144
GuardLogStatement Logger calls should be surrounded by log level guards. 2 160
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 162
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 169
LongVariable Avoid excessively long variable names like filesListedInManifests 3 176
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 178
GuardLogStatement Logger calls should be surrounded by log level guards. 2 178
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 178
MethodNamingConventions The static method name 'CheckAllFilesInPayloadDirAreListedInAllManifests' doesn't match '[a-z][a-zA-Z0-9]*' 1 188–194
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 190
GuardLogStatement Logger calls should be surrounded by log level guards. 2 190
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 190

nl/knaw/dans/bagit/verify/PayloadFileExistsInAllManifestsVistor.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 30
CommentRequired Field comments are required 3 33
CommentRequired Public method and constructor comments are required 3 35–38
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 44
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 44
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 46
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 46
GuardLogStatement Logger calls should be surrounded by log level guards. 2 50

nl/knaw/dans/bagit/verify/PayloadFileExistsInAtLeastOneManifestVistor.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 31
CommentRequired Field comments are required 3 34
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 34
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 34
CommentRequired Field comments are required 3 35
LongVariable Avoid excessively long variable names like filesListedInManifests 3 35
CommentRequired Public method and constructor comments are required 3 37–40
LongVariable Avoid excessively long variable names like filesListedInManifests 3 37
GuardLogStatement Logger calls should be surrounded by log level guards. 2 45
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 50
GuardLogStatement Logger calls should be surrounded by log level guards. 2 52

nl/knaw/dans/bagit/verify/QuickVerifier.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 34
CommentSize Comment is too large: Line too long 3 35
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 39
CommentRequired Field comments are required 3 39
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 39
CommentRequired Field comments are required 3 40
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 40
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 40
LongVariable Avoid excessively long variable names like PAYLOAD_OXUM_REGEX 3 41
CommentRequired Field comments are required 3 41
CommentSize Comment is too large: Line too long 3 48
GuardLogStatement Logger calls should be surrounded by log level guards. 2 55
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 55
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 55
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 63
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 65
CommentSize Comment is too large: Too many lines 3 71–81
CommentSize Comment is too large: Line too long 3 72
CommentSize Comment is too large: Line too long 3 77
CommentSize Comment is too large: Line too long 3 78
CommentSize Comment is too large: Line too long 3 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 84
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 88
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 89
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 89
GuardLogStatement Logger calls should be surrounded by log level guards. 2 89
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 91
GuardLogStatement Logger calls should be surrounded by log level guards. 2 91
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 91
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'numberOfFiles' (lines '92'-'107'). 5 92–107
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 92
GuardLogStatement Logger calls should be surrounded by log level guards. 2 97
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 4 5 97
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 4 5 97
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105

nl/knaw/dans/bagit/writer/BagWriter.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 39
CommentRequired Field comments are required 3 39
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 39
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 40
CommentRequired Field comments are required 3 40
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 40
CommentSize Comment is too large: Too many lines 3 46–57
CommentSize Comment is too large: Line too long 3 48
CommentSize Comment is too large: Line too long 3 49
CommentSize Comment is too large: Line too long 3 50
CommentSize Comment is too large: Line too long 3 56
GuardLogStatement Logger calls should be surrounded by log level guards. 2 59
GuardLogStatement Logger calls should be surrounded by log level guards. 2 62
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 64
GuardLogStatement Logger calls should be surrounded by log level guards. 2 66
GuardLogStatement Logger calls should be surrounded by log level guards. 2 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 72
GuardLogStatement Logger calls should be surrounded by log level guards. 2 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 76
GuardLogStatement Logger calls should be surrounded by log level guards. 2 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 80
GuardLogStatement Logger calls should be surrounded by log level guards. 2 81
LongVariable Avoid excessively long variable names like updatedTagManifests 3 83
CommentSize Comment is too large: Line too long 3 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 118
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 121

nl/knaw/dans/bagit/writer/BagitFileWriter.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 35
CommentRequired Field comments are required 3 35
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 35
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 36
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 36
CommentRequired Field comments are required 3 36
CommentSize Comment is too large: Too many lines 3 42–50
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 53
GuardLogStatement Logger calls should be surrounded by log level guards. 2 53
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 53
GuardLogStatement Logger calls should be surrounded by log level guards. 2 59
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 59
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 59
GuardLogStatement Logger calls should be surrounded by log level guards. 2 63
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 63
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 63

nl/knaw/dans/bagit/writer/FetchWriter.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 33
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 36
CommentRequired Field comments are required 3 36
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 36
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 37
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 37
CommentRequired Field comments are required 3 37
CommentSize Comment is too large: Too many lines 3 43–52
CommentSize Comment is too large: Line too long 3 44
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 54
GuardLogStatement Logger calls should be surrounded by log level guards. 2 54
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 54
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'fetchFilePath' (lines '55'-'65'). 5 55–65
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 61
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 61
GuardLogStatement Logger calls should be surrounded by log level guards. 2 61
ShortVariable Avoid variables with short names like sb 3 68

nl/knaw/dans/bagit/writer/ManifestWriter.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 37
CommentRequired Field comments are required 3 37
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 37
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 38
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 38
CommentRequired Field comments are required 3 38
CommentSize Comment is too large: Too many lines 3 44–53
GuardLogStatement Logger calls should be surrounded by log level guards. 2 55
CommentSize Comment is too large: Too many lines 3 59–68
GuardLogStatement Logger calls should be surrounded by log level guards. 2 70
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 79
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 80
GuardLogStatement Logger calls should be surrounded by log level guards. 2 80
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 87
CommentSize Comment is too large: Line too long 3 88
CommentSize Comment is too large: Line too long 3 89
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 91
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 91
GuardLogStatement Logger calls should be surrounded by log level guards. 2 91

nl/knaw/dans/bagit/writer/MetadataWriter.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 35
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 35
CommentRequired Field comments are required 3 35
CommentRequired Field comments are required 3 36
CommentRequired Field comments are required 3 37
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 37
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 37
CommentSize Comment is too large: Too many lines 3 43–52
CommentSize Comment is too large: Line too long 3 44
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'bagInfoFilePath' (lines '54'-'56'). 5 54–56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 58
GuardLogStatement Logger calls should be surrounded by log level guards. 2 58
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 58
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 58
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 68
GuardLogStatement Logger calls should be surrounded by log level guards. 2 68
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 68

nl/knaw/dans/bagit/writer/PayloadWriter.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
VariableNamingConventions Variables that are final and static should be all capitals, 'logger' is not all capitals. 1 38
CommentRequired Field comments are required 3 38
FieldNamingConventions The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' 1 38
CommentRequired Field comments are required 3 39
FieldNamingConventions The constant name 'messages' doesn't match '[A-Z][A-Z_0-9]*' 1 40
VariableNamingConventions Variables that are final and static should be all capitals, 'messages' is not all capitals. 1 40
CommentRequired Field comments are required 3 40
CommentSize Comment is too large: Line too long 3 47
DefaultPackage Use explicit scoping instead of the default package private level 3 49–64
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the writeVersionDependentPayloadFiles method if you want a default access modifier 3 49–64
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'bagitDir' (lines '50'-'53'). 5 50–53
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 60
CommentSize Comment is too large: Too many lines 3 66–75
CommentSize Comment is too large: Line too long 3 70
GuardLogStatement Logger calls should be surrounded by log level guards. 2 77
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'fetchPaths' (lines '78'-'98'). 5 78–98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
LongVariable Avoid excessively long variable names like relativePayloadPath 3 82
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 84
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 1 5 85
GuardLogStatement Logger calls should be surrounded by log level guards. 2 85
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 85
InvalidSlf4jMessageFormat Too many arguments, expected 0 argument but have 2 5 89
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 2 5 89
GuardLogStatement Logger calls should be surrounded by log level guards. 2 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 105

nl/knaw/dans/bagit/writer/RelativePathWriter.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 1–15
CommentSize Comment is too large: Line too long 3 2
CommentSize Comment is too large: Line too long 3 32
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 40
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 41

Suppressed Violations

Filename Rule message Suppression type Reason
nl/knaw/dans/bagit/conformance/BagProfileChecker.java Avoid instantiating new objects inside loops annotation
nl/knaw/dans/bagit/conformance/ManifestChecker.java This class has too many methods, consider refactoring it. annotation
nl/knaw/dans/bagit/conformance/ManifestChecker.java Avoid empty catch blocks annotation
nl/knaw/dans/bagit/conformance/ManifestChecker.java When doing a String.toLowerCase()/toUpperCase() call, use a Locale annotation
nl/knaw/dans/bagit/conformance/ManifestChecker.java When doing a String.toLowerCase()/toUpperCase() call, use a Locale annotation
nl/knaw/dans/bagit/conformance/ManifestChecker.java When doing a String.toLowerCase()/toUpperCase() call, use a Locale annotation
nl/knaw/dans/bagit/conformance/profile/BagitProfileDeserializer.java Avoid instantiating new objects inside loops annotation
nl/knaw/dans/bagit/creator/BagCreator.java This class has too many methods, consider refactoring it. annotation
nl/knaw/dans/bagit/domain/Metadata.java When doing a String.toLowerCase()/toUpperCase() call, use a Locale annotation
nl/knaw/dans/bagit/domain/Metadata.java When doing a String.toLowerCase()/toUpperCase() call, use a Locale annotation
nl/knaw/dans/bagit/domain/Metadata.java When doing a String.toLowerCase()/toUpperCase() call, use a Locale annotation
nl/knaw/dans/bagit/domain/Metadata.java When doing a String.toLowerCase()/toUpperCase() call, use a Locale annotation
nl/knaw/dans/bagit/domain/Metadata.java When doing a String.toLowerCase()/toUpperCase() call, use a Locale annotation
nl/knaw/dans/bagit/hash/Hasher.java Avoid instantiating new objects inside loops annotation
nl/knaw/dans/bagit/hash/StandardSupportedAlgorithms.java When doing a String.toLowerCase()/toUpperCase() call, use a Locale annotation
nl/knaw/dans/bagit/reader/FetchReader.java Avoid instantiating new objects inside loops annotation
nl/knaw/dans/bagit/reader/FetchReader.java Avoid instantiating new objects inside loops annotation
nl/knaw/dans/bagit/verify/BagVerifier.java Avoid instantiating new objects inside loops annotation
nl/knaw/dans/bagit/verify/ManifestVerifier.java Avoid instantiating new objects inside loops annotation
nl/knaw/dans/bagit/writer/BagWriter.java Avoid instantiating new objects inside loops annotation